From: Nathan Lynch <nathanl@linux.ibm.com>
To: Haren Myneni <haren@linux.ibm.com>,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com
Subject: Re: [PATCH 2/3] powerpc/pseries/vas: Add VAS migration handler
Date: Tue, 01 Feb 2022 10:12:47 -0600 [thread overview]
Message-ID: <87mtjasgzk.fsf@linux.ibm.com> (raw)
In-Reply-To: <17bb8ed6bfc450ec89bd12169d43858a2ba33bca.camel@linux.ibm.com>
Haren Myneni <haren@linux.ibm.com> writes:
> On Mon, 2022-01-31 at 10:37 -0600, Nathan Lynch wrote:
>> Haren Myneni <haren@linux.ibm.com> writes:
>> > Since the VAS windows belong to the VAS hardware resource, the
>> > hypervisor expects the partition to close them on source partition
>> > and reopen them after the partition migrated on the destination
>> > machine.
>>
>> Not clear to me what "expects" really means here. Would it be
>> accurate to say "requires" instead? If the OS fails to close the
>> windows before suspend, what happens?
>
> I will change it to 'requires' - These VAS windows have to be closed
> before migration so that these windows / credits will be available to
> other LPARs on the source machine.
I'll rephrase.
I want to know whether the architecture (PAPR or whichever doc) imposes
a requirement on the OS (i.e. using words like "must") to close the
windows, or does it merely make a recommendation ("should"), or is it
silent on the subject?
In your testing, if Linux has windows open at the time of calling
ibm,suspend-me, does the call fail or succeed?
next prev parent reply other threads:[~2022-02-01 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 1:18 [PATCH 0/3] powerpc/pseries/vas: VAS/NXGZIP support with LPM Haren Myneni
2022-01-29 1:19 ` [PATCH 1/3] powerpc/pseries/vas: Modify reconfig open/close functions for migration Haren Myneni
2022-01-29 1:20 ` [PATCH 2/3] powerpc/pseries/vas: Add VAS migration handler Haren Myneni
2022-01-31 16:37 ` Nathan Lynch
2022-02-01 4:59 ` Haren Myneni
2022-02-01 16:12 ` Nathan Lynch [this message]
2022-01-29 1:21 ` [PATCH 3/3] powerpc/pseries/vas: Disable window open during migration Haren Myneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtjasgzk.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=haren@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).