From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1D6BC2D0A3 for ; Fri, 6 Nov 2020 16:46:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AD9D2151B for ; Fri, 6 Nov 2020 16:46:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="fO+7b1Ae" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AD9D2151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CSRB642NVzDrBB for ; Sat, 7 Nov 2020 03:46:54 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=nathanl@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=fO+7b1Ae; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CSR7N5zQ3zDrBY for ; Sat, 7 Nov 2020 03:44:32 +1100 (AEDT) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A6GWbEE176788 for ; Fri, 6 Nov 2020 11:44:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=V2iR+bsLRq/BHMr8FKrrfoqtFEb7GZD2FHyLUBuA8I0=; b=fO+7b1AexaQtd2CyMnYmyK4w9bP5FBnHrRg90fuiQqUi/rMYFKGLJRjvzeNMyZg5d2LO YuOi1UU0FUTli1lxw3Wxmcyrd3JYpm5LRlh5Cd+5RTEGuS4OC66MrOsGzok9Ar6gxqZZ H/YD7aJy+LChL5Q4kkcNU5GQGXkFYAWo3i+U67azTuBDLFMm/iSTVblYCoOOywTPsLOn B9gsIdkfTvJKUcQrzk4OApfzhqSh9iyrAyP3HVDX2t8uMMUehVKYvniAQsM9qpGzsMuA qZwBQxtBDX6fXpvqzz6rkg/ctnehhN0GvWVwARTp6DCD9OkD8FwrTlOQc6bhr79uCm8a 4A== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 34n3qrec36-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 06 Nov 2020 11:44:29 -0500 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0A6GhGpO004432 for ; Fri, 6 Nov 2020 16:44:28 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma03dal.us.ibm.com with ESMTP id 34hs33twjr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 06 Nov 2020 16:44:28 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0A6GiJlT7995932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 6 Nov 2020 16:44:19 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33D556E053; Fri, 6 Nov 2020 16:44:27 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E91376E04C; Fri, 6 Nov 2020 16:44:26 +0000 (GMT) Received: from localhost (unknown [9.65.230.88]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 6 Nov 2020 16:44:26 +0000 (GMT) From: Nathan Lynch To: Andrew Donnellan , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 02/29] powerpc/rtas: prevent suspend-related sys_rtas use on LE In-Reply-To: <95c8b599-f939-ad28-5671-cfbf7436508e@linux.ibm.com> References: <20201030011805.1224603-1-nathanl@linux.ibm.com> <20201030011805.1224603-3-nathanl@linux.ibm.com> <87r1pfkj7z.fsf@linux.ibm.com> <95c8b599-f939-ad28-5671-cfbf7436508e@linux.ibm.com> Date: Fri, 06 Nov 2020 10:44:26 -0600 Message-ID: <87mtzujuz9.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-06_06:2020-11-05, 2020-11-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 phishscore=0 malwarescore=0 clxscore=1015 mlxscore=0 mlxlogscore=943 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011060115 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tyreld@linux.ibm.com, brking@linux.ibm.com, mmc@linux.vnet.ibm.com, cforno12@linux.vnet.ibm.com, drt@linux.vnet.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Andrew Donnellan writes: > On 30/10/20 11:10 pm, Nathan Lynch wrote: >>> And there's a zero chance that drmgr will ever be fixed on LE? >> >> It's always used the sysfs interface on LE, and the only way to provoke >> it to attempt the syscalls is by doing something like this before >> running the migration: >> >> # echo 0 > /tmp/fake_api_version >> # mount -o bind,ro /tmp/fake_api_version /sys/kernel/mobility/api_version >> >> So I'm not aware of any circumstance that would actually motivate >> someone to make it work on LE. I'd say it's more likely that drmgr will >> drop its support for using the syscall altogether. >> > > Okay. librtas should handle the error fine, so I don't have any huge > objection to this, though perhaps a documentation patch to librtas to > mention that these calls are BE-only would be in order. Good suggestion, I've drafted a documentation change as well as an attempt to mark the appropriate APIs deprecated for LE here: https://github.com/nathanlynch/librtas/tree/topic/document-suspend-filter which I'll send to Tyrel if/when the Linux change is staged.