From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F56C433DF for ; Tue, 9 Jun 2020 17:57:14 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 698EC206D5 for ; Tue, 9 Jun 2020 17:57:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 698EC206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49hHrQ6GyCzDqYX for ; Wed, 10 Jun 2020 03:57:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=vaibhav@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49hHmn2YsrzDqLh for ; Wed, 10 Jun 2020 03:54:00 +1000 (AEST) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 059HVxpj058938; Tue, 9 Jun 2020 13:53:24 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 31hrn8rws0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jun 2020 13:53:24 -0400 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 059HWFp2060351; Tue, 9 Jun 2020 13:53:23 -0400 Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 31hrn8rwr9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jun 2020 13:53:23 -0400 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 059HokEx027473; Tue, 9 Jun 2020 17:53:21 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma05fra.de.ibm.com with ESMTP id 31g2s7tkgt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jun 2020 17:53:21 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 059HrJ0058786250 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Jun 2020 17:53:19 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 46F8F4C059; Tue, 9 Jun 2020 17:53:19 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C10794C040; Tue, 9 Jun 2020 17:53:15 +0000 (GMT) Received: from vajain21-in-ibm-com (unknown [9.85.73.146]) by d06av22.portsmouth.uk.ibm.com (Postfix) with SMTP; Tue, 9 Jun 2020 17:53:15 +0000 (GMT) Received: by vajain21-in-ibm-com (sSMTP sendmail emulation); Tue, 09 Jun 2020 23:23:14 +0530 From: Vaibhav Jain To: Dan Williams , kernel test robot Subject: Re: [PATCH v11 5/6] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods In-Reply-To: References: <20200607131339.476036-6-vaibhav@linux.ibm.com> <202006090059.o4CE5D9b%lkp@intel.com> Date: Tue, 09 Jun 2020 23:23:14 +0530 Message-ID: <87mu5cw2gl.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-09_10:2020-06-09, 2020-06-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 phishscore=0 clxscore=1011 adultscore=0 mlxlogscore=999 cotscore=-2147483648 suspectscore=0 spamscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006090130 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Santosh Sivaraj , kbuild-all@lists.01.org, linux-nvdimm , "Aneesh Kumar K . V" , Linux Kernel Mailing List , Steven Rostedt , clang-built-linux , Oliver O'Halloran , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Thanks Dan for the consideration and taking time to look into this. My responses below: Dan Williams writes: > On Mon, Jun 8, 2020 at 5:16 PM kernel test robot wrote: >> >> Hi Vaibhav, >> >> Thank you for the patch! Perhaps something to improve: >> >> [auto build test WARNING on powerpc/next] >> [also build test WARNING on linus/master v5.7 next-20200605] >> [cannot apply to linux-nvdimm/libnvdimm-for-next scottwood/next] >> [if your patch is applied to the wrong git tree, please drop us a note to help >> improve the system. BTW, we also suggest to use '--base' option to specify the >> base tree in git format-patch, please see https://stackoverflow.com/a/37406982] >> >> url: https://github.com/0day-ci/linux/commits/Vaibhav-Jain/powerpc-papr_scm-Add-support-for-reporting-nvdimm-health/20200607-211653 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next >> config: powerpc-randconfig-r016-20200607 (attached as .config) >> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e429cffd4f228f70c1d9df0e5d77c08590dd9766) >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # install powerpc cross compiling tool for clang build >> # apt-get install binutils-powerpc-linux-gnu >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All warnings (new ones prefixed by >>, old ones prefixed by <<): >> >> In file included from :1: >> >> ./usr/include/asm/papr_pdsm.h:69:20: warning: field 'hdr' with variable sized type 'struct nd_cmd_pkg' not at the end of a struct or class is a GNU extension [-Wgnu-variable-sized-type-not-at-end] >> struct nd_cmd_pkg hdr; /* Package header containing sub-cmd */ > > Hi Vaibhav, > [.] > This looks like it's going to need another round to get this fixed. I > don't think 'struct nd_pdsm_cmd_pkg' should embed a definition of > 'struct nd_cmd_pkg'. An instance of 'struct nd_cmd_pkg' carries a > payload that is the 'pdsm' specifics. As the code has it now it's > defined as a superset of 'struct nd_cmd_pkg' and the compiler warning > is pointing out a real 'struct' organization problem. > > Given the soak time needed in -next after the code is finalized this > there's no time to do another round of updates and still make the v5.8 > merge window. Agreed that this looks bad, a solution will probably need some more review cycles resulting in this series missing the merge window. I am investigating into the possible solutions for this reported issue and made few observations: I see command pkg for Intel, Hpe, Msft and Hyperv families using a similar layout of embedding nd_cmd_pkg at the head of the command-pkg. struct nd_pdsm_cmd_pkg is following the same pattern. struct nd_pdsm_cmd_pkg { struct nd_cmd_pkg hdr; /* other members */ }; struct ndn_pkg_msft { struct nd_cmd_pkg gen; /* other members */ }; struct nd_pkg_intel { struct nd_cmd_pkg gen; /* other members */ }; struct ndn_pkg_hpe1 { struct nd_cmd_pkg gen; /* other members */ }; Even though other command families implement similar command-package layout they were not flagged (yet) as they are (I am guessing) serviced in vendor acpi drivers rather than in kernel like in case of papr-scm command family. So, I think this issue is not just specific to papr-scm command family introduced in this patch series but rather across all other command families. Every other command family assumes 'struct nd_cmd_pkg_hdr' to be embeddable and puts it at the beginning of their corresponding command-packages. And its only a matter of time when someone tries filtering/handling of vendor specific commands in nfit module when they hit similar issue. Possible Solutions: * One way would be to redefine 'struct nd_cmd_pkg' to mark field 'nd_payload[]' from a flexible array to zero sized array as 'nd_payload[0]'. This should make 'struct nd_cmd_pkg' embeddable and clang shouldn't report 'gnu-variable-sized-type-not-at-end' warning. Also I think this change shouldn't introduce any ABI change. * Another way to solve this issue might be to redefine 'struct nd_pdsm_cmd_pkg' to below removing the 'struct nd_cmd_pkg' member. This struct should immediately follow the 'struct nd_cmd_pkg' command package when sent to libnvdimm: struct nd_pdsm_cmd_pkg { __s32 cmd_status; /* Out: Sub-cmd status returned back */ __u16 reserved[2]; /* Ignored and to be used in future */ __u8 payload[]; }; This should remove the flexible member nc_cmd_pkg.nd_payload from the struct with just one remaining at the end. However this would make accessing the [in|out|fw]_size members of 'struct nd_cmd_pkg' difficult for the pdsm servicing functions. Any other solution that you think, may solve this issue ? Thanks, -- ~ Vaibhav