linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Christophe LEROY <christophe.leroy@c-s.fr>,
	npiggin@gmail.com, benh@kernel.crashing.org, paulus@samba.org,
	mpe@ellerman.id.au, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V3 5/5] arch/powerpc/mm/hugetlb: NestMMU workaround for hugetlb mprotect RW upgrade
Date: Wed, 05 Dec 2018 09:39:27 +0530	[thread overview]
Message-ID: <87o9a062dk.fsf@linux.ibm.com> (raw)
In-Reply-To: <3b87e008-eb08-f41c-ef70-1986360c5df9@c-s.fr>

Christophe LEROY <christophe.leroy@c-s.fr> writes:
> diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
>> index 8cf035e68378..39d33a3d0dc6 100644
>> --- a/arch/powerpc/mm/hugetlbpage.c
>> +++ b/arch/powerpc/mm/hugetlbpage.c
>> @@ -912,3 +912,32 @@ int gup_hugepte(pte_t *ptep, unsigned long sz, unsigned long addr,
>>   
>>   	return 1;
>>   }
>> +
>> +#ifdef CONFIG_PPC_BOOK3S_64
>
> Could this go in hugetlbpage-hash64.c instead to avoid the #ifdef sequence ?
>

yes. I will send updated patch as reply

-aneesh


  reply	other threads:[~2018-12-05  4:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05  3:09 [PATCH V3 0/5] NestMMU pte upgrade workaround for mprotect Aneesh Kumar K.V
2018-12-05  3:09 ` [PATCH V3 1/5] mm: Update ptep_modify_prot_start/commit to take vm_area_struct as arg Aneesh Kumar K.V
2018-12-06 21:58   ` kbuild test robot
2018-12-08 15:32     ` Aneesh Kumar K.V
2018-12-05  3:09 ` [PATCH V3 2/5] mm: update ptep_modify_prot_commit to take old pte value " Aneesh Kumar K.V
2018-12-05  4:02   ` Christophe LEROY
2018-12-05  4:06     ` Aneesh Kumar K.V
2018-12-05  4:42       ` Christophe LEROY
2018-12-05  3:09 ` [PATCH V3 3/5] arch/powerpc/mm: Nest MMU workaround for mprotect RW upgrade Aneesh Kumar K.V
2018-12-18 17:21   ` Christoph Hellwig
2018-12-05  3:09 ` [PATCH V3 4/5] mm/hugetlb: Add prot_modify_start/commit sequence for hugetlb update Aneesh Kumar K.V
2018-12-05  3:09 ` [PATCH V3 5/5] arch/powerpc/mm/hugetlb: NestMMU workaround for hugetlb mprotect RW upgrade Aneesh Kumar K.V
2018-12-05  3:57   ` Christophe LEROY
2018-12-05  4:09     ` Aneesh Kumar K.V [this message]
2018-12-05  4:11   ` [PATCH V3 updated] " Aneesh Kumar K.V
2018-12-08  1:04     ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9a062dk.fsf@linux.ibm.com \
    --to=aneesh.kumar@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).