linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: regressions@lists.linux.dev
Cc: linux-kernel@vger.kernel.org, jarkko@kernel.org,
	naveen.n.rao@linux.ibm.com, linux-integrity@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support
Date: Fri, 28 Jun 2024 10:54:31 +1000	[thread overview]
Message-ID: <87pls1lwe0.fsf@mail.lhotse> (raw)
In-Reply-To: <20240617193408.1234365-1-stefanb@linux.ibm.com>

Stefan Berger <stefanb@linux.ibm.com> writes:
> Fix the following type of error message caused by a missing call to
> tpm2_sessions_init() in the IBM vTPM driver:
>
> [    2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error 0x01C4
> [    2.987140] ima: Error Communicating to TPM chip, result: -14
>
> Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation")
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
>  drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index d3989b257f42..1e5b107d1f3b 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
>  		rc = tpm2_get_cc_attrs_tbl(chip);
>  		if (rc)
>  			goto init_irq_cleanup;
> +
> +		rc = tpm2_sessions_init(chip);
> +		if (rc)
> +			goto init_irq_cleanup;
>  	}
>  
>  	return tpm_chip_register(chip);

#regzbot ^introduced: d2add27cf2b8 

  parent reply	other threads:[~2024-06-28  0:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 19:34 [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support Stefan Berger
2024-06-17 19:42 ` James Bottomley
2024-06-17 19:56   ` Stefan Berger
2024-06-17 20:05     ` James Bottomley
2024-06-17 20:17       ` Stefan Berger
2024-06-19 22:34 ` Stefan Berger
2024-06-28 15:00   ` Linux regression tracking (Thorsten Leemhuis)
2024-07-01 15:22     ` Jarkko Sakkinen
2024-07-01 18:29       ` Stefan Berger
2024-07-01 19:01         ` Jarkko Sakkinen
2024-07-01 19:14           ` Stefan Berger
2024-07-02 23:48             ` Jarkko Sakkinen
2024-07-02 23:57               ` Jarkko Sakkinen
2024-07-03  0:34                 ` Jarkko Sakkinen
2024-07-03  0:48                   ` Jarkko Sakkinen
2024-07-03  1:00                     ` Jarkko Sakkinen
2024-07-01 14:53   ` Jarkko Sakkinen
2024-06-28  0:54 ` Michael Ellerman [this message]
2024-06-28 16:39   ` James Bottomley
2024-06-28 17:21     ` Stefan Berger
2024-07-02  0:19     ` Michael Ellerman
2024-07-01 14:52 ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pls1lwe0.fsf@mail.lhotse \
    --to=mpe@ellerman.id.au \
    --cc=jarkko@kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=regressions@lists.linux.dev \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).