From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9651CC4345F for ; Fri, 19 Apr 2024 07:23:29 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=Ajstnip1; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VLR2R6LJJz3dC2 for ; Fri, 19 Apr 2024 17:23:27 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=Ajstnip1; dkim-atps=neutral Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VLR1c5Fp0z3blb for ; Fri, 19 Apr 2024 17:22:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1713511364; bh=y6+LJ/HKVZ3t3mY/lApMl/GxR/GrG1RUjmP1/5KDxJs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Ajstnip1AJQziYYZob5+/WWQw9OkiQ6HqYW6enqSgR3T/CWGp6JpdFQzdsfgccveC waF4b2KpmGDJhW0uaIjTruByYiknefTsAbDI1CsuVxIlgr8/egc0ybcsQUt/stAUIl raR314f9lFE/RXTMwibjefIPDZ5AB0qSRczs793ZKaBylcevAra8Aht5IRKNIO774t aG3dAb/4j2sOMbQ5Iwk3E6LlLVt1iq7SfpU3a55AkDG8Tl4O8gD7WxKyVt/tO8JQz4 7Nt41dgDBlJelLCvurGlsjRwLg8I8J1MJ2FAUJ37oJvYirJXZTHvc5s+9d7acvo/rM EtC7Y6dv3fK3A== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4VLR1c0rdDz4x0D; Fri, 19 Apr 2024 17:22:43 +1000 (AEST) From: Michael Ellerman To: Chris Packham , Andi Shyti , Abhinav Jain Subject: Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup In-Reply-To: <2ea08951-3613-4ed5-a2b2-dd4887105ac3@alliedtelesis.co.nz> References: <20240415161220.8347-1-jain.abhinav177@gmail.com> <2ea08951-3613-4ed5-a2b2-dd4887105ac3@alliedtelesis.co.nz> Date: Fri, 19 Apr 2024 17:22:43 +1000 Message-ID: <87plulakak.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "javier.carrasco.cruz@gmail.com" , "linux-kernel@vger.kernel.org" , Julia Lawall , "linux-i2c@vger.kernel.org" , "skhan@linuxfoundation.org" , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Chris Packham writes: > On 16/04/24 08:54, Andi Shyti wrote: >> Hi Abhinav, >> >>> /* Enable I2C interrupts for mpc5121 */ >>> - node_ctrl = of_find_compatible_node(NULL, NULL, >>> - "fsl,mpc5121-i2c-ctrl"); >>> + struct device_node *node_ctrl __free(device_node) = >> How have you tested this? > > I'm not sure I know anyone that still has a mpc5121. Maybe someone on > linuxppc-dev? Not that I know of. The driver loads on my T4240, but doesn't hit the right paths to test this patch. No objection to it being merged though. cheers