* Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup [not found] ` <vegjt4pcl2x2wmwso6ajbihqc6rpbup5knycnz76jz3zfbfpp4@opxek6apu3w4> @ 2024-04-16 3:59 ` Chris Packham 2024-04-16 14:07 ` Andi Shyti 2024-04-19 7:22 ` Michael Ellerman 0 siblings, 2 replies; 4+ messages in thread From: Chris Packham @ 2024-04-16 3:59 UTC (permalink / raw) To: Andi Shyti, Abhinav Jain Cc: javier.carrasco.cruz@gmail.com, linux-kernel@vger.kernel.org, Julia Lawall, linux-i2c@vger.kernel.org, skhan@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org On 16/04/24 08:54, Andi Shyti wrote: > Hi Abhinav, > >> /* Enable I2C interrupts for mpc5121 */ >> - node_ctrl = of_find_compatible_node(NULL, NULL, >> - "fsl,mpc5121-i2c-ctrl"); >> + struct device_node *node_ctrl __free(device_node) = > How have you tested this? I'm not sure I know anyone that still has a mpc5121. Maybe someone on linuxppc-dev? I did try to take the patch for a spin on my T2081RDB but I'm having some userland issues on it for some reason (unrelated to this change). The kernel boot does discover a few peripherals hanging of the I2C interface but I'm not in a position to offer up a Tested-by and I've run out of time to debug why my board is unhappy. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup 2024-04-16 3:59 ` [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup Chris Packham @ 2024-04-16 14:07 ` Andi Shyti 2024-04-16 14:09 ` Andi Shyti 2024-04-19 7:22 ` Michael Ellerman 1 sibling, 1 reply; 4+ messages in thread From: Andi Shyti @ 2024-04-16 14:07 UTC (permalink / raw) To: Chris Packham Cc: Abhinav Jain, javier.carrasco.cruz@gmail.com, linux-kernel@vger.kernel.org, Julia Lawall, linux-i2c@vger.kernel.org, skhan@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org Hi Chris, On Tue, Apr 16, 2024 at 03:59:13AM +0000, Chris Packham wrote: > On 16/04/24 08:54, Andi Shyti wrote: > >> /* Enable I2C interrupts for mpc5121 */ > >> - node_ctrl = of_find_compatible_node(NULL, NULL, > >> - "fsl,mpc5121-i2c-ctrl"); > >> + struct device_node *node_ctrl __free(device_node) = > > How have you tested this? > > I'm not sure I know anyone that still has a mpc5121. Maybe someone on > linuxppc-dev? that's why I was asking, this would be the first driver in i2c using Rob's __free(device_node). > I did try to take the patch for a spin on my T2081RDB but I'm having > some userland issues on it for some reason (unrelated to this change). > The kernel boot does discover a few peripherals hanging of the I2C > interface but I'm not in a position to offer up a Tested-by and I've run > out of time to debug why my board is unhappy. Thanks for giving it a try. Andi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup 2024-04-16 14:07 ` Andi Shyti @ 2024-04-16 14:09 ` Andi Shyti 0 siblings, 0 replies; 4+ messages in thread From: Andi Shyti @ 2024-04-16 14:09 UTC (permalink / raw) To: Chris Packham Cc: Abhinav Jain, javier.carrasco.cruz@gmail.com, linux-kernel@vger.kernel.org, Julia Lawall, linux-i2c@vger.kernel.org, skhan@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org On Tue, Apr 16, 2024 at 04:07:48PM +0200, Andi Shyti wrote: > On Tue, Apr 16, 2024 at 03:59:13AM +0000, Chris Packham wrote: > > On 16/04/24 08:54, Andi Shyti wrote: > > >> /* Enable I2C interrupts for mpc5121 */ > > >> - node_ctrl = of_find_compatible_node(NULL, NULL, > > >> - "fsl,mpc5121-i2c-ctrl"); > > >> + struct device_node *node_ctrl __free(device_node) = > > > How have you tested this? > > > > I'm not sure I know anyone that still has a mpc5121. Maybe someone on > > linuxppc-dev? > > that's why I was asking, this would be the first driver in i2c > using Rob's __free(device_node). Jonathan's, of course :-) Andi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup 2024-04-16 3:59 ` [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup Chris Packham 2024-04-16 14:07 ` Andi Shyti @ 2024-04-19 7:22 ` Michael Ellerman 1 sibling, 0 replies; 4+ messages in thread From: Michael Ellerman @ 2024-04-19 7:22 UTC (permalink / raw) To: Chris Packham, Andi Shyti, Abhinav Jain Cc: javier.carrasco.cruz@gmail.com, linux-kernel@vger.kernel.org, Julia Lawall, linux-i2c@vger.kernel.org, skhan@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org Chris Packham <Chris.Packham@alliedtelesis.co.nz> writes: > On 16/04/24 08:54, Andi Shyti wrote: >> Hi Abhinav, >> >>> /* Enable I2C interrupts for mpc5121 */ >>> - node_ctrl = of_find_compatible_node(NULL, NULL, >>> - "fsl,mpc5121-i2c-ctrl"); >>> + struct device_node *node_ctrl __free(device_node) = >> How have you tested this? > > I'm not sure I know anyone that still has a mpc5121. Maybe someone on > linuxppc-dev? Not that I know of. The driver loads on my T4240, but doesn't hit the right paths to test this patch. No objection to it being merged though. cheers ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-19 7:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240415161220.8347-1-jain.abhinav177@gmail.com>
[not found] ` <vegjt4pcl2x2wmwso6ajbihqc6rpbup5knycnz76jz3zfbfpp4@opxek6apu3w4>
2024-04-16 3:59 ` [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup Chris Packham
2024-04-16 14:07 ` Andi Shyti
2024-04-16 14:09 ` Andi Shyti
2024-04-19 7:22 ` Michael Ellerman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).