From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22347C54E41 for ; Tue, 5 Mar 2024 09:14:23 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=e03rf2/c; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Tpqd95rBdz3vbV for ; Tue, 5 Mar 2024 20:14:21 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=e03rf2/c; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.198.163.18; helo=mgamail.intel.com; envelope-from=jani.nikula@intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TpqcL25DRz2xPZ for ; Tue, 5 Mar 2024 20:13:36 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709630019; x=1741166019; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=3mXN8KKW4waYOcWzjRN9oSLaIcwuzNcqm3YSkZxcpzY=; b=e03rf2/cqM2P0ok41exl59H6wytKKIx7JFpmVe1r7Mm0cFITvE5NiX7A zFyvYbB5QJbfp+Sy5EWg/nSsi28yAUrbcQ1bNbiGSd5hm2oKxYCbXCoxg jJjS7r0PjcLAULjf6nFvWcD/4AGllEk7ijKPynVi9ZXBB/eJzpMnrha0H mQWPMLtyRQIaMzCav8XVYTbgE6GVfF8zJOq+DIL6ePg5AM4e3+XqRMhxc MmqHMM43pGqiKKrySo8F7R19e9h4Ii1Etj+NvcqRFMWnrMuaWR76s6EA7 u65HoVIcP284IhbBnFwh+JmMYVz7WDrXGPFSt9LnL1dJa8yJ4uiDf9IsE w==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="4031545" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="4031545" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 01:13:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="46836038" Received: from omakhlou-mobl4.amr.corp.intel.com (HELO localhost) ([10.252.51.143]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 01:13:24 -0800 From: Jani Nikula To: Thomas Zimmermann , mpe@ellerman.id.au, naresh.kamboju@linaro.org, deller@gmx.de, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com Subject: Re: [PATCH v2 2/3] macintosh/via-pmu-backlight: Include In-Reply-To: <20240305090910.26742-3-tzimmermann@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240305090910.26742-1-tzimmermann@suse.de> <20240305090910.26742-3-tzimmermann@suse.de> Date: Tue, 05 Mar 2024 11:13:20 +0200 Message-ID: <87plw92g9b.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, lkft-triage@lists.linaro.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 05 Mar 2024, Thomas Zimmermann wrote: > Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the > backlight header has recently been removed from . Add it to > via-pmu-backlight.c to get the necessary symbols. > > Reported-by: Naresh Kamboju > Closes: https://lore.kernel.org/dri-devel/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com/ > Signed-off-by: Thomas Zimmermann > Fixes: 11b4eedfc87d ("fbdev: Do not include in header") > Cc: Thomas Zimmermann > Cc: Jani Nikula > Cc: Helge Deller > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org Reviewed-by: Jani Nikula > --- > drivers/macintosh/via-pmu-backlight.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c > index c2d87e7fa85be..89450645c2305 100644 > --- a/drivers/macintosh/via-pmu-backlight.c > +++ b/drivers/macintosh/via-pmu-backlight.c > @@ -10,6 +10,7 @@ > > #include > #include > +#include > #include > #include -- Jani Nikula, Intel