From: Michael Ellerman <mpe@ellerman.id.au>
To: linuxppc-dev@lists.ozlabs.org
Cc: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>,
satheera@in.ibm.com, Nicholas Piggin <npiggin@gmail.com>
Subject: Printing of machine check severity
Date: Tue, 05 Mar 2019 17:57:47 +1100 [thread overview]
Message-ID: <87pnr5vmdw.fsf@concordia.ellerman.id.au> (raw)
Hi all,
RE: https://github.com/linuxppc/issues/issues/230
> Host dmesg throws lot of below SLB [Multihit] HMI's
>
> [295216.837358] Severe Machine check interrupt [Recovered]
> [295216.837365] Harmless Hypervisor Maintenance interrupt [Recovered]
> [295216.837374] Guest NIP: c00000000024a7dc
> [295216.837378] Error detail: Processor Recovery done
> [295216.837381] HMER: 2040000000000000
> [295216.837388] Initiator: CPU
> [295216.837406] Error type: SLB [Multihit]
> [295216.837415] Effective address: d00000000316c400
Paul points out that these aren't severe errors from the hosts point of
view, and possibly not even for the guest.
I think the key problem here is that we print "Severe" for most types of
MCEs, even though some really aren't.
That comes from the severity being set to `MCE_SEV_ERROR_SYNC` in the
i/derror table.
All the enum values are `MCE_SEV` so the value is actually `ERROR_SYNC`,
which I think means "synchronous error". That is correct. But I don't
think it's correct that all synchronous errors are "severe".
We also have some errors in `mce_ierror_table` that are marked
`MCE_SEV_FATAL` and then have a comment saying `/* ASYNC is fatal */`.
So I feel like we have severity and sync/async conflated in the severity
value, ie. we should split out sync/async and then have a separate
severity field.
We need to be careful because a few places check for `MCE_SEV_ERROR_SYNC`,
it's not *only* used for the severity string.
We could then mark eg. SLB multi-hits as warning rather than severe.
Additionally we probably want to use the `in_guest` flag to modulate the
severity or the message, or both.
cheers
reply other threads:[~2019-03-05 6:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnr5vmdw.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=satheera@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox