From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Meelis Roos <mroos@linux.ee>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: UBSAN: Undefined behaviour in arch/powerpc/kernel/cputable.c
Date: Sat, 10 Sep 2016 21:42:55 +0530 [thread overview]
Message-ID: <87poobpwc8.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.LRH.2.20.1609091556420.29746@math.ut.ee>
Meelis Roos <mroos@linux.ee> writes:
> Got this on my PowerPC G4 (533 MHz, PowerPC 7410, PowerMac3,4 platform),
> with gcc version 5.3.1 20160509 (Debian 5.3.1-19):
>
> [ 0.000000] ================================================================================
> [ 0.000000] UBSAN: Undefined behaviour in arch/powerpc/kernel/cputable.c:2240:25
> [ 0.000000] shift exponent 32 is too large for 32-bit type 'long unsigned int'
> [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.8.0-rc5-00075-gd71f058 #106
> [ 0.000000] Call Trace:
> [ 0.000000] [c0a5ff10] [c03aa588] ubsan_epilogue+0x18/0x4c (unreliable)
> [ 0.000000] [c0a5ff20] [c03aab38] __ubsan_handle_shift_out_of_bounds+0xe8/0x13c
> [ 0.000000] [c0a5ffa0] [c07c42d0] cpu_feature_keys_init+0xa0/0xb8
> [ 0.000000] [c0a5ffd0] [c07ca1fc] setup_feature_keys+0x14/0x24
> [ 0.000000] [c0a5ffe0] [c07c6c74] machine_init+0x18/0x58
> [ 0.000000] [c0a5fff0] [c000341c] start_here+0x38/0x78
> [ 0.000000] ================================================================================
>
>
Can you try
diff --git a/arch/powerpc/include/asm/cpu_has_feature.h b/arch/powerpc/include/asm/cpu_has_feature.h
index 2ef55f8968a2..b312b152461b 100644
--- a/arch/powerpc/include/asm/cpu_has_feature.h
+++ b/arch/powerpc/include/asm/cpu_has_feature.h
@@ -15,7 +15,7 @@ static inline bool early_cpu_has_feature(unsigned long feature)
#ifdef CONFIG_JUMP_LABEL_FEATURE_CHECKS
#include <linux/jump_label.h>
-#define NUM_CPU_FTR_KEYS 64
+#define NUM_CPU_FTR_KEYS BITS_PER_LONG
extern struct static_key_true cpu_feature_keys[NUM_CPU_FTR_KEYS];
prev parent reply other threads:[~2016-09-10 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 13:05 UBSAN: Undefined behaviour in arch/powerpc/kernel/cputable.c Meelis Roos
2016-09-10 9:51 ` Michael Ellerman
2016-09-11 9:12 ` Meelis Roos
2016-09-10 16:12 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poobpwc8.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).