From: Thomas Gleixner <tglx@linutronix.de>
To: David Wang <00107082@163.com>,
richard.henderson@linaro.org, linux@armlinux.org.uk,
catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org,
chenhuacai@kernel.org, kernel@xen0n.name,
James.Bottomley@HansenPartnership.com, deller@gmx.de,
mpe@ellerman.id.au, paul.walmsley@sifive.com,
ysato@users.sourceforge.jp, dalias@libc.org,
glaubitz@physik.fu-berlin.de, davem@davemloft.net,
andreas@gaisler.com, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, chris@zankel.net,
jcmvbkbc@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
loongarch@lists.linux.dev, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
David Wang <00107082@163.com>
Subject: Re: [PATCH] kernel/irq/proc: performance: replace seq_printf with seq_put_decimal_ull_width
Date: Fri, 08 Nov 2024 15:25:13 +0100 [thread overview]
Message-ID: <87r07lol9y.ffs@tglx> (raw)
In-Reply-To: <20241103080552.4787-1-00107082@163.com>
David!
On Sun, Nov 03 2024 at 16:05, David Wang wrote:
$Subject: [PATCH] kernel/irq/proc: performance: ...
That's not a valid subsystem prefix.
> seq_printf is costy, when stress reading /proc/interrupts, profiling indicates
> seq_printf takes about ~47% of show_interrupts samples:
Also please follow the documentation for denoting functions in change
logs:
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#function-references-in-changelogs
> arch/alpha/kernel/irq.c | 8 +--
> arch/arm/kernel/smp.c | 4 +-
> arch/arm64/kernel/smp.c | 3 +-
> arch/csky/kernel/smp.c | 4 +-
> arch/loongarch/kernel/smp.c | 2 +-
> arch/parisc/kernel/irq.c | 34 ++++++------
> arch/powerpc/kernel/irq.c | 44 ++++++++--------
> arch/riscv/kernel/smp.c | 3 +-
> arch/sh/kernel/irq.c | 4 +-
> arch/sparc/kernel/irq_32.c | 12 ++---
> arch/sparc/kernel/irq_64.c | 4 +-
> arch/x86/kernel/irq.c | 100 ++++++++++++++++++------------------
> arch/xtensa/kernel/irq.c | 2 +-
> arch/xtensa/kernel/smp.c | 4 +-
> kernel/irq/proc.c | 6 ++-
There is no dependency on these changes. So please split them up into
seperate patches for core and the individual architectures.
Thanks,
tglx
next parent reply other threads:[~2024-11-08 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241103080552.4787-1-00107082@163.com>
2024-11-08 14:25 ` Thomas Gleixner [this message]
2024-11-08 15:28 ` [PATCH] kernel/irq/proc: performance: replace seq_printf with seq_put_decimal_ull_width David Wang
2024-12-11 22:32 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r07lol9y.ffs@tglx \
--to=tglx@linutronix.de \
--cc=00107082@163.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=andreas@gaisler.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=glaubitz@physik.fu-berlin.de \
--cc=guoren@kernel.org \
--cc=jcmvbkbc@gmail.com \
--cc=kernel@xen0n.name \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paul.walmsley@sifive.com \
--cc=richard.henderson@linaro.org \
--cc=sparclinux@vger.kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).