From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1722C5475B for ; Thu, 14 Mar 2024 10:51:51 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=EwLkY4XJ; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TwPMV3X6lz3vYc for ; Thu, 14 Mar 2024 21:51:50 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=EwLkY4XJ; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TwPLd6hX5z3d4L for ; Thu, 14 Mar 2024 21:51:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1710413464; bh=DRdiHGqYqxjEF8hsA5ZH+kEbHXJ9gHLyaDJurUBUBU8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EwLkY4XJ/XL6m9O01lkeRqb+bFGM+QvljzvF4nbDCTUEioyZoYoIMNbpMjw/ibU28 UaZLGEMxbKyyHXpBTLDqSOa9gMjkeg2wXcWsO6hB8FLPuII9r/uZvQoQ0axiGR9ZjI OJoivYUdbYAy72HQQGSNAgfMInJNDl8EOWJ+HVA5xsz7/fbUPckzgw0OYMh8LYCfrh AHfU/K+/T+ds+0JQChBbJxC55hFG5D9mFQW1g+NpydlfUrwdlDsmwljjoxuLlD129X mFlBgg//ha/jnCRFFGrUoPpkT996Tpp2gKmcMniglSQgR/+XtpLQBEQyF4GYKAqh/K 6sl4QGJjol9Vw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4TwPLZ4lVKz4wnr; Thu, 14 Mar 2024 21:51:02 +1100 (AEDT) From: Michael Ellerman To: Herve Codina Subject: Re: [PATCH v7 1/5] net: wan: Add support for QMC HDLC In-Reply-To: <20240314081200.5af62fab@bootlin.com> References: <20240307113909.227375-1-herve.codina@bootlin.com> <20240307113909.227375-2-herve.codina@bootlin.com> <87ttl93f7i.fsf@mail.lhotse> <20240314081200.5af62fab@bootlin.com> Date: Thu, 14 Mar 2024 21:51:01 +1100 Message-ID: <87r0gd2iju.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Andy Shevchenko , Vadim Fedorenko , Ratheesh Kannoth , Yury Norov , netdev@vger.kernel.org, Rasmus Villemoes , linux-kernel@vger.kernel.org, Eric Dumazet , Mark Brown , Thomas Petazzoni , Jakub Kicinski , Paolo Abeni , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Herve Codina writes: > Hi Michael, > > On Thu, 14 Mar 2024 10:05:37 +1100 > Michael Ellerman wrote: > >> Hi Herve, >>=20 >> Herve Codina writes: > .. >> This breaks when building as a module (eg. ppc32_allmodconfig): >>=20 >> In file included from ../include/linux/device/driver.h:21, >> from ../include/linux/device.h:32, >> from ../include/linux/dma-mapping.h:8, >> from ../drivers/net/wan/fsl_qmc_hdlc.c:13: >> ../drivers/net/wan/fsl_qmc_hdlc.c:405:25: error: =E2=80=98qmc_hdlc_dri= ver=E2=80=99 undeclared here (not in a function); did you mean =E2=80=98qmc= _hdlc_probe=E2=80=99? >> 405 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver); >> | ^~~~~~~~~~~~~~~ >>=20 >>=20 >> IIUIC it should be pointing to the table, not the driver, so: >>=20 >> diff --git a/drivers/net/wan/fsl_qmc_hdlc.c b/drivers/net/wan/fsl_qmc_hd= lc.c >> index 5fd7ed325f5b..705c3681fb92 100644 >> --- a/drivers/net/wan/fsl_qmc_hdlc.c >> +++ b/drivers/net/wan/fsl_qmc_hdlc.c >> @@ -402,7 +402,7 @@ static const struct of_device_id qmc_hdlc_id_table[]= =3D { >> { .compatible =3D "fsl,qmc-hdlc" }, >> {} /* sentinel */ >> }; >> -MODULE_DEVICE_TABLE(of, qmc_hdlc_driver); >> +MODULE_DEVICE_TABLE(of, qmc_hdlc_id_table); >>=20 >> static struct platform_driver qmc_hdlc_driver =3D { >> .driver =3D { >>=20 >>=20 >> Which then builds correctly. > > My bad, I missed that one. > I fully agree with your modification. > > Do you want me to make a patch (copy/paste of your proposed modification) > or do you plan to send the patch on your side ? Yes if you can please turn it into a proper patch and submit it. No need to add my SoB, it's trivial. cheers