From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE21DC33CA9 for ; Tue, 14 Jan 2020 01:18:26 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EDE0207FF for ; Tue, 14 Jan 2020 01:18:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="iiEg66QF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EDE0207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47xXdr2HRwzDqP6 for ; Tue, 14 Jan 2020 12:18:24 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47xXXs2XYTzDqNP for ; Tue, 14 Jan 2020 12:14:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=iiEg66QF; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 47xXXs0VLLz9s29; Tue, 14 Jan 2020 12:14:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1578964445; bh=5WG/hTgko72eJb6ASFMHgV3Z1SBkyLvrrVTGzmn5hO0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iiEg66QFo8Hf2feigqNc0bYtnRksK0+jNNzpr/xvPsYEOmOdXLH6FheBvl68A8AOj aOzYmanBp5glgJwHJIHhs0bUlwpWnqj8yk82bJGAVUrxu7NKfQR6ODqX0tAYD2cq00 UDd8uh34XRVF4FVDqx260iXpVph8rYZ7/cZO17onoO3LOkSJwuy/tqAy2UgTrg41a8 SY8wBO+SIeTbNxxEyDDBbxulb5XiC+Bjs+A8cxH2LJMCa4gjdlL+XrG073q+r4Jqes pbKB2TWd8h7/e3KNWK/3htCBun+3dAJLK4MNc/Lnjc6BAnWOweWCUJbiCi33xgW8Nl tQcIw4QN6vgsw== From: Michael Ellerman To: =?utf-8?Q?C=C3=A9dric?= Le Goater Subject: Re: [PATCH] powerpc/xive: discard ESB load value when interrupt is invalid In-Reply-To: <76f76082-81ee-4957-c45b-151f0cd6e6b6@kaod.org> References: <20200113130118.27969-1-clg@kaod.org> <76f76082-81ee-4957-c45b-151f0cd6e6b6@kaod.org> Date: Tue, 14 Jan 2020 11:14:09 +1000 Message-ID: <87r202alge.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Frederic Barrat , linuxppc-dev@lists.ozlabs.org, Greg Kurz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" C=C3=A9dric Le Goater writes: > On 1/13/20 2:01 PM, C=C3=A9dric Le Goater wrote: >> From: Frederic Barrat >>=20 >> A load on an ESB page returning all 1's means that the underlying >> device has invalidated the access to the PQ state of the interrupt >> through mmio. It may happen, for example when querying a PHB interrupt >> while the PHB is in an error state. >>=20 >> In that case, we should consider the interrupt to be invalid when >> checking its state in the irq_get_irqchip_state() handler. > > > and we need also these tags : > > Fixes: da15c03b047d ("powerpc/xive: Implement get_irqchip_state method fo= r XIVE to fix shutdown race") > Cc: stable@vger.kernel.org # v5.3+ I added those, although it's v5.4+, as the offending commit was first included in v5.4-rc1. cheers