From: Michael Ellerman <mpe@ellerman.id.au>
To: Daniel Axtens <dja@axtens.net>, linuxppc-dev@lists.ozlabs.org
Cc: Daniel Axtens <dja@axtens.net>
Subject: Re: [PATCH] powerpc/configs: Disable /dev/port in skiroot defconfig
Date: Fri, 28 Jun 2019 11:45:33 +1000 [thread overview]
Message-ID: <87r27escsi.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20190627053008.29315-1-dja@axtens.net>
Daniel Axtens <dja@axtens.net> writes:
> While reviewing lockdown patches, I discovered that we still enable
> /dev/port (CONFIG_DEVPORT) in skiroot.
>
> We don't need it. Deselect CONFIG_DEVPORT for skiroot.
Why don't we need it? :)
cheers
> diff --git a/arch/powerpc/configs/skiroot_defconfig b/arch/powerpc/configs/skiroot_defconfig
> index 5ba131c30f6b..b2e8f37156eb 100644
> --- a/arch/powerpc/configs/skiroot_defconfig
> +++ b/arch/powerpc/configs/skiroot_defconfig
> @@ -212,6 +212,7 @@ CONFIG_IPMI_WATCHDOG=y
> CONFIG_HW_RANDOM=y
> CONFIG_TCG_TPM=y
> CONFIG_TCG_TIS_I2C_NUVOTON=y
> +# CONFIG_DEVPORT is not set
> CONFIG_I2C=y
> # CONFIG_I2C_COMPAT is not set
> CONFIG_I2C_CHARDEV=y
> --
> 2.20.1
next prev parent reply other threads:[~2019-06-28 1:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 5:30 [PATCH] powerpc/configs: Disable /dev/port in skiroot defconfig Daniel Axtens
2019-06-28 1:45 ` Michael Ellerman [this message]
2019-07-02 6:41 ` Daniel Axtens
2019-08-28 4:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r27escsi.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=dja@axtens.net \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).