Re: kernel bug in "Drop WIMG in favour of new constants"?

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

Benjamin Herrenschmidt <benh@au1.ibm.com> writes:

>=20=09
>  <1466054627.5400.5.camel@ellerman.id.au>
>=20=09
>=20=09
>  <20160616055746.GC22590@birch.djwong.org>
>=20=09
>=20=09
>  <8737oda1lt.fsf@skywalker.in.ibm.com>
>=20=09
> 	 <87ziql8l93.fsf@skywalker.in.ibm.com>
> 	 <87wplp8kxh.fsf@skywalker.in.ibm.com>
> Organization: IBM Australia
> Content-Type: text/plain; charset=3D"UTF-8"
> X-Mailer: Evolution 3.20.3 (3.20.3-1.fc24)=20
> Mime-Version: 1.0
> Content-Transfer-Encoding: 8bit
>
> On Thu, 2016-06-16 at 16:22 +0530, Aneesh Kumar K.V wrote:
>> Hmm Qemu=C2=A0 does
>>=20
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Looks like an IO address */
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* FIXME: What WIMG combinati=
ons could be sensible for IO?
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * For now we allow WIMG=
=3D010x, but are there others? */
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* FIXME: Should we check aga=
inst registered IO addresses? */
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ((ptel & (HPTE64_R_W | HPT=
E64_R_I | HPTE64_R_M)) !=3D HPTE64_R_I) {
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 retur=
n H_PARAMETER;
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
>>=20
>> -aneesh
>
> And what do we get ? M ? I think we might be OR'ing it
> unconditionaly...
>

Yes we do. We did that for a long time. But we had special case handing
for the lpar case. I already sent a patch to update that. But I am not
sure whether to fix this in the kernel or in Qemu.

-aneesh