From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19D2AC4332F for ; Mon, 6 Nov 2023 06:07:54 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=blvpfEmG; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SP19N4tGGz3cHf for ; Mon, 6 Nov 2023 17:07:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=blvpfEmG; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SP18P43Fvz3c2V for ; Mon, 6 Nov 2023 17:07:01 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699250815; bh=gv51mywp9ecOX1RzxcZintnhCsjrqp3x4ZC5Y3ZTTNk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=blvpfEmGE+F3r0Fuw6ybL9XiF7bRdCdhL0xCmScANvLLocPL5eJpTsbOysaUJychF 9EVAypYfGN5Jpnw6/bjQzpz1yuCnsIyx6XqfLeFhc3LrdL9N/13gadKies37NVe4Al uDtIAebgpKKAdDyR2iFoRS81YIlEagqJsBD2ZK37QryXxjmaxT7Dn42mP+0wohL7pj /1M1OoP8ZgitJbhdYR86vIpvWyWq0GyaIJ/3ra1rsw5pvN2eKIi8i7H1gDsAhMk8JR 6RqMDqBcz7czNexkVLMY4E3vrCZVXe055JmCuKUjOfcgrtYCC+0NvxT9tylfoqE3yw MJbvWOb49lHYA== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SP18B6F9xz4wd0; Mon, 6 Nov 2023 17:06:50 +1100 (AEDT) From: Michael Ellerman To: Anshuman Khandual , "Daniel Walker (danielwa)" , Christophe Leroy , "Aneesh Kumar K . V" , david@redhat.com Subject: Re: mm/debug_vm_pgtable.c:860 warning triggered In-Reply-To: References: Date: Mon, 06 Nov 2023 17:06:46 +1100 Message-ID: <87sf5jqutl.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-mm@kvack.org" , "David Beazley \(dbeazley\)" , "linuxppc-dev@lists.ozlabs.org" , "xe-linux-external\(mailer list\)" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Anshuman Khandual writes: > Hello Daniel, > > This test just ensures that PFN is preserved during pte <--> swap pte transformations > , and the warning here seems to have been caused by powerpc platform specific helpers > and/or its pte_t representation. Adding powerpc folks and platform mailing list here. Doesn't the test need a similar treatment to: 2321ba3e3733 ("mm/debug_vm_pgtable: more pte_swp_exclusive() sanity checks") Which said: Especially, the pfn_pte() is dodgy when the swap PTE layout differs heavily from ordinary PTEs. Let's properly construct a swap PTE from swap type+offset. cheers