From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4853FC433F5 for ; Wed, 18 May 2022 04:51:15 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4L30tn1zK3z3cG7 for ; Wed, 18 May 2022 14:51:13 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=kW2YFNy6; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4L30t61j24z2yHt for ; Wed, 18 May 2022 14:50:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=kW2YFNy6; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4L30t33mDSz4xVP; Wed, 18 May 2022 14:50:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1652849436; bh=LNLCsDkug1r3kbDai+5TpbpwIL81Sv0gHUxwzASZmbE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kW2YFNy6Mydz+OYZr3o72Pk6e8jcaOqaS4BhdS8uSWLiEn9PZpa7vpwkALAOyPog8 UW5WkzqvTIHaTUHky6hhvCbL6o4qIDreX25VuFfk5x1pzkEUhloYFNFsr5gmQ8VnPN cjIivInaZnZ/wqO8YgTCpRLyMfYhRMqsZtJ+GeqPoN6lBpd9isvAGSH8Zpp+UzjLIb HkGjENzvewWhBq42NbX/3UVxAgywDSpd+CmNpuQGB112pt4GuqEgXBzuw5UZVpNv4M TLqM2j4Cnchw8HUHHJV+LZUUmQNfj7xMbxsex2HAeEMrTqirY/vQvbDUPG6V7Z8hei tyO05KtVFELtA== From: Michael Ellerman To: YueHaibing , Christophe Leroy , "benh@kernel.crashing.org" , "paulus@samba.org" Subject: Re: [PATCH -next] powerpc/book3e: Fix build error In-Reply-To: <8b169642-5d32-4135-93a7-4969515d1ab0@huawei.com> References: <20220517094830.27560-1-yuehaibing@huawei.com> <0e8b7931-9bfb-1948-c141-c4e612ba0fe6@csgroup.eu> <8b169642-5d32-4135-93a7-4969515d1ab0@huawei.com> Date: Wed, 18 May 2022 14:50:34 +1000 Message-ID: <87sfp7o351.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" YueHaibing writes: > On 2022/5/17 18:45, Christophe Leroy wrote: >> Le 17/05/2022 =C3=A0 11:48, YueHaibing a =C3=A9crit=C2=A0: >>> arch/powerpc/mm/nohash/fsl_book3e.c: In function =E2=80=98relocate_init= =E2=80=99: >>> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration = of function =E2=80=98early_get_first_memblock_info=E2=80=99 [-Werror=3Dimpl= icit-function-declaration] >>> early_get_first_memblock_info(__va(dt_ptr), &size); >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> Add missing include file linux/of_fdt.h to fix this. >>> >>> Signed-off-by: YueHaibing >>=20 >> Thats for fixing that. >>=20 >> Reviewed-by: Christophe Leroy >>=20 >> It means we don't have any defconfig for 32 bits booke with=20 >> CONFIG_RELOCATABLE ? > > Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/= configs It's selected by CRASH_DUMP, which is in ppc64_defconfig. But it's not enabled in corenet32_smp_defconfig which is what I build, or any of the other 85xx configs. I guess it should be, I think it's true that RELOCATABLE=3Dy exercises more interesting code paths? cheers