From: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
To: Michael Ellerman <patch-notifications@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Subject: Re: [v3, 1/8] powerpc/perf/hv-24x7: Fix passing of catalog version number
Date: Mon, 03 Jul 2017 10:23:13 -0300 [thread overview]
Message-ID: <87shidvem6.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <3x0nQH2RsPz9sNx@ozlabs.org>
Michael Ellerman <patch-notifications@ellerman.id.au> writes:
> On Thu, 2017-06-29 at 21:55:31 UTC, Thiago Jung Bauermann wrote:
>> H_GET_24X7_CATALOG_PAGE needs to be passed the version number obtained from
>> the first catalog page obtained previously. This is a 64 bit number, but
>> create_events_from_catalog truncates it to 32-bit.
>>
>> This worked on POWER8, but POWER9 actually uses the upper bits so the call
>> fails with H_P3 because the hypervisor doesn't recognize the version.
>>
>> This patch also adds the hcall return code to the error message, which is
>> helpful when debugging the problem.
>>
>> Fixes: 5c5cd7b50259 ("powerpc/perf/hv-24x7: parse catalog and populate sysfs with events")
>> Reviewed-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
>> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
>
> Series applied to powerpc next, thanks.
>
> https://git.kernel.org/powerpc/c/12bf85a71000af7419b19b5e909109
Thanks!
--
Thiago Jung Bauermann
IBM Linux Technology Center
next prev parent reply other threads:[~2017-07-03 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 21:55 [PATCH v3 0/8] Support for 24x7 hcall interface version 2 Thiago Jung Bauermann
2017-06-29 21:55 ` [PATCH v3 1/8] powerpc/perf/hv-24x7: Fix passing of catalog version number Thiago Jung Bauermann
2017-07-02 11:01 ` [v3, " Michael Ellerman
2017-07-03 13:23 ` Thiago Jung Bauermann [this message]
2017-06-29 21:55 ` [PATCH v3 2/8] powerpc/perf/hv-24x7: Fix off-by-one error in request_buffer check Thiago Jung Bauermann
2017-06-29 21:55 ` [PATCH v3 3/8] powerpc/perf/hv-24x7: Properly iterate through results Thiago Jung Bauermann
2017-06-29 21:55 ` [PATCH v3 4/8] powerpc-perf/hx-24x7: Don't log failed hcall twice Thiago Jung Bauermann
2017-06-29 21:55 ` [PATCH v3 5/8] powerpc/perf/hv-24x7: Fix return value of hcalls Thiago Jung Bauermann
2017-06-29 21:55 ` [PATCH v3 6/8] powerpc/perf/hv-24x7: Minor improvements Thiago Jung Bauermann
2017-06-29 21:55 ` [PATCH v3 7/8] powerpc/perf/hv-24x7: Support v2 of the hypervisor API Thiago Jung Bauermann
2017-06-29 21:55 ` [PATCH v3 8/8] powerpc/perf/hv-24x7: Aggregate result elements on POWER9 SMT8 Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shidvem6.fsf@linux.vnet.ibm.com \
--to=bauerman@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=patch-notifications@ellerman.id.au \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).