From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EB35C61DC4 for ; Thu, 27 Aug 2026 14:09:22 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4hW3Kr5pL4z2y2b; Fri, 28 Aug 2026 00:09:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1787839760; cv=none; b=j5kqdokuDN77qE2erkbfuFN+chiVCXsILz0hnQwnpty+rYSJ2aY0qz2YnejfooFaVbgnTjbuM5qhaZpi8vU/K7b9gm6hi3WPSnYOi9sSaYrUOHIbvYWvz/wuAYo4htP8cjA9FCCLDHIA1O+XtsAi0xex6kh7EIyLL72m2nVh4BvwtfG9S31ILWZ/2WMGIjjT3dG6bMncg1sJoRE5mnfs1sTSwOKhd3/UQ6LdJM/tLx/SK0MXdE2Gd6l9j9sj7V4QmPlCvJt3Owxaml7pt/+Zllg1g4Fs+M5CIOfUjg4zg6f08lYDPxLuSQS8RO5+0mWR2EnM0INEdaLn64V3ByiBKg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1787839760; c=relaxed/relaxed; bh=jUv72F1CZ2VZ+muiH7wSHWEPJWb0NfGiT0vKTZxrsRs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=e5uTyLSNrmp6/mBZ/6Gq2uen8vclV4jTpsu1xe/h0msmbSVy7Lc9nNgOIdbk5szFiobQux1Zg7WN0PpFvEBQyaoXUuXEqfKGnTTLzUZQrU1o0H/N4wGJINcI5c3LLS0BXu3Tg958kigt5L51O8pBupjira23fH2jAYmeU/hzODiRBE2+oGeQF4rzhYSgFfPTecDpS8K0GGLNUtVDmD/8Udl1yUWvCFIwNTNUfH9xNCj7mgM+2gWQhIXpCSgX/W/RmWBOtEhLZE6oEgXqZOi5bg5PRfKOUO46gwrCJvfHGG9/PWA8ElWR1KKniLg7mq5KAw8EQ+tVxjNPS+bneLx82A== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=XeOxH0Ba; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=davemarq@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=XeOxH0Ba; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=davemarq@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4hW3Kq43Dgz2xGr for ; Fri, 28 Aug 2026 00:09:19 +1000 (AEST) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67RCVjgA2892044; Thu, 27 Aug 2026 14:09:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=jUv72F1CZ2VZ+muiH7wSHWEPJWb0Nf GiT0vKTZxrsRs=; b=XeOxH0BaPo6EierO/OxycqYOzcQRTwh4WU1oC4Xv7n09DQ fgOZXSK4w6d4p0LmaWR3lhyNmlLqRMzRzVyzyu+PbyZGdNElSlT54ffN6wXsMpgj 0kucTuCH541MWXUPjHgA7whfCi+7dtSNyFfcoElTYdF697B2C6f7TBSs1Wcqa86m 7Yj3dhvVa6pNWBKWKV3EASu3bMZDjjnJcjxM6DmCetI14jaIFUggeD+7tRTS/0kg PNc3rpAp2us15UVRGERphlEF8e1HC8xzgMCFIAHZu4X4nhNPbguyLlGz41rmmjVE dnHnqtWznxDdVeyt08/ijLWmbgWAyH3Akc1Jl2Jg== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4g716j5vc0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 14:09:06 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 67RDuSn2014432; Thu, 27 Aug 2026 14:09:05 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4g7qkhgcpe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 14:09:05 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67RE94lq31326892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Aug 2026 14:09:04 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CD7558056; Thu, 27 Aug 2026 14:09:04 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 602C258050; Thu, 27 Aug 2026 14:09:03 +0000 (GMT) Received: from d (unknown [9.61.140.220]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Thu, 27 Aug 2026 14:09:03 +0000 (GMT) From: Dave Marquardt To: Muhammad Falak R Wani Cc: Tyrel Datwyler , "Martin K. Petersen" , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 2/2] scsi: ibmvfc: document protocol parameter of ibmvfc_alloc_target() In-Reply-To: References: Date: Thu, 27 Aug 2026 09:09:02 -0500 Message-ID: <87tsofzmdd.fsf@linux.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDExOCBTYWx0ZWRfX/V83t/o+zq3R zDwfzHkmU61fHio0j/y6bbG1SCUiwNMf1JY9mftiEO8h89sNELgcSRpoMyARoGPxEwBvt61ahvt vZLU6aSpEkOaW+LFogmdWF3bVadtY+E= X-Proofpoint-GUID: kxfrtCgwlP2vG6ucvy97NfEMHp0Zm1uQ X-Proofpoint-ORIG-GUID: 3ursgP67x9H7o8WqP8Ch_7MBJ3WlNbDg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDExOCBTYWx0ZWRfXwri3qrqzusuE /LrABrdGgAJHGwS2siHeRZpv9LQFsOGk2sPKDxk3XZEpPoEc+QGhuDcYD2DsZz9tEroJEVp+HC5 5o7k0NhQ0qcTDV8ETENIecgb3HH8CjRPmhf5CWgbqlut3wKNRwg8j/C2iyjJpsegNmeGVx2tn5v STjQDldOgOkNnpu9PGFPsoy3Wkt2wTfV4iNW3J+LCgaiZPJJjbbKk34AF7Ml/ASIoxVlcxQagXv gEMDtvxtQu+Lm/xEzE/VHKehzx457N56ZtKKM2zjLKTkQ8rHbTu7PMFu8em7Nw8Spq61lZNGCPD dCduy59D7iBT+APeYhJXjpI0HcozkCVa59i0ADQEReLMcPCchleRKvvw+0FYSY+TRiGQgD9bJAs +x4NolvjKniI+rBZYyZoXfEiXGvDblXFJ5ukGVgdLFEDtrP6XvkyDWtnfCe3dXYe+mr3TO7eHPh zJOclFFvRfJIFU1uc1w== X-Authority-Analysis: v=2.4 cv=H7brBeYi c=1 sm=1 tr=0 ts=6a904502 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=pGLkceISAAAA:8 a=VnNF1IyMAAAA:8 a=kifdfqukGkPUHOnBEzIA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_05,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1011 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270118 Muhammad Falak R Wani writes: > Commit 249313b3f7b5 ("scsi: ibmvfc: allocate targets based on protocol") > added a protocol parameter to ibmvfc_alloc_target() but did not describe > it in the function's kernel-doc comment, so a W=1 build warns: > > drivers/scsi/ibmvscsi/ibmvfc-core.c:4996: warning: Function parameter > or struct member 'protocol' not described in 'ibmvfc_alloc_target' > > Add the missing parameter description. > > Fixes: 249313b3f7b5 ("scsi: ibmvfc: allocate targets based on protocol") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202608270829.lHI1FAdO-lkp@intel.com/ > Signed-off-by: Muhammad Falak R Wani > --- > drivers/scsi/ibmvscsi/ibmvfc-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/ibmvscsi/ibmvfc-core.c b/drivers/scsi/ibmvscsi/ibmvfc-core.c > index d1956552698e0..6fd4c601f978c 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc-core.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c > @@ -4987,6 +4987,7 @@ static void ibmvfc_tgt_query_target(struct ibmvfc_target *tgt) > * ibmvfc_alloc_target - Allocate and initialize an ibmvfc target > * @vhost: ibmvfc host struct > * @target: Holds SCSI ID to allocate target forand the WWPN > + * @protocol: protocol of the target to allocate > * > * Returns: > * 0 on success / other on failure Reviewed-by: Dave Marquardt