Re: [PATCH v2] ALSA: aoa: i2sbus: clear stale prepared state

Takashi Iwai
2026-04-01T07:59:59Z

On Tue, 31 Mar 2026 23:14:04 +0200,
Cássio Gabriel wrote:
>
> The i2sbus PCM code uses pi->active to constrain the sibling stream to
> an already prepared duplex format and rate in i2sbus_pcm_open().
>
> That state is set from i2sbus_pcm_prepare(), but the current code only
> clears it on close. As a result, the sibling stream can inherit stale
> constraints after the prepared state has been torn down.
>
> Clear pi->active when hw_params() or hw_free() tears down the prepared
> state, and set it again only after prepare succeeds.
>
> Replace the stale FIXME in the duplex constraint comment with a description
> of the current driver behavior: i2sbus still programs a single shared
> transport configuration for both directions, so mixed formats are not
> supported in duplex mode.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202604010125.AvkWBYKI-lkp@intel.com/
> Fixes: f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
> Cc: stable@vger.kernel.org
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>

Applied to for-next branch now. Thanks.

Takashi