From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BB00C43334 for ; Mon, 25 Jul 2022 12:23:29 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LrzjD0RmXz3c3Z for ; Mon, 25 Jul 2022 22:23:28 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=QMXMm72W; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Lrzh94YKpz3c52 for ; Mon, 25 Jul 2022 22:22:33 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=QMXMm72W; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Lrzh93WXkz4xD9; Mon, 25 Jul 2022 22:22:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1658751753; bh=5Fl0RHlEgXuBE2WPauMEneaFCDwh//pAstIMXhcK4IQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QMXMm72WGBtS6Qf4YunmB9MFolK45aDmMEUUmEeRDcGMBGvAJ3FbBz/aN/D5KIg2X s0SoQinKa2Cd1l4joa0rdtgPew9uj87CfgyTzuo7MZ/UHAvsBGtVjiFBs5fd3IqCgO tOKpb8Vec5dLh1oGpqV51mIEsqxu7CKR1WGaviPraHvsyVLzwqXx017DKYWMZQPfwq /OUuwgwhBrUDBkfAGVyRwcgg8U6HHx/ypEE75o+nAdG+gzAsxEpe2Zl14iSyCyj1/a dV+OFBRViom+W2CX2faWctnMv2lPgqniUxqtTGcvgBUGqybQitIKSOYnzMh7idmkHL D7S7jZnKO2Q4g== From: Michael Ellerman To: Yury Norov , linux-kernel@vger.kernel.org, Andy Shevchenko , Rasmus Villemoes , linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , Stephen Rothwell Subject: Re: [PATCH 1/2] powerpc: drop dependency on in archrandom.h In-Reply-To: <20220723214537.2054208-2-yury.norov@gmail.com> References: <20220723214537.2054208-1-yury.norov@gmail.com> <20220723214537.2054208-2-yury.norov@gmail.com> Date: Mon, 25 Jul 2022 22:22:33 +1000 Message-ID: <87tu75bcvq.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yury Norov Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Yury Norov writes: > archrandom.h includes to refer ppc_md. This causes > circular header dependency, if generic nodemask.h includes random.h: > > In file included from include/linux/cred.h:16, > from include/linux/seq_file.h:13, > from arch/powerpc/include/asm/machdep.h:6, > from arch/powerpc/include/asm/archrandom.h:5, > from include/linux/random.h:109, > from include/linux/nodemask.h:97, > from include/linux/list_lru.h:12, > from include/linux/fs.h:13, > from include/linux/compat.h:17, > from arch/powerpc/kernel/asm-offsets.c:12: > include/linux/sched.h:1203:9: error: unknown type name 'nodemask_t' > 1203 | nodemask_t mems_allowed; > | ^~~~~~~~~~ > > Fix it by removing dependency from archrandom.h > > Signed-off-by: Yury Norov > --- > arch/powerpc/include/asm/archrandom.h | 9 +-------- > arch/powerpc/kernel/setup-common.c | 11 +++++++++++ > 2 files changed, 12 insertions(+), 8 deletions(-) Acked-by: Michael Ellerman cheers