From: Daniel Axtens <dja@axtens.net>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>, linuxppc-dev@ozlabs.org
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc/eeh: eeh_pci_enable(): fix checking of post-request state
Date: Tue, 27 Oct 2015 10:09:30 +1100 [thread overview]
Message-ID: <87twpdp6qd.fsf@gamma.ozlabs.ibm.com> (raw)
In-Reply-To: <1445581186-10533-1-git-send-email-andrew.donnellan@au1.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
> diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
> index 40e4d4a..d757e7c 100644
> --- a/arch/powerpc/kernel/eeh.c
> +++ b/arch/powerpc/kernel/eeh.c
> @@ -677,7 +677,7 @@ int eeh_pci_enable(struct eeh_pe *pe, int function)
> /* Check if the request is finished successfully */
> if (active_flag) {
> rc = eeh_ops->wait_state(pe, PCI_BUS_RESET_WAIT_MSEC);
> - if (rc <= 0)
> + if (rc < 0)
> return rc;
>
> if (rc & active_flag)
Reviewed-by: Daniel Axtens <dja@axtens.net>
> --
> Andrew Donnellan Software Engineer, OzLabs
> andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra
> +61 2 6201 8874 (work) IBM Australia Limited
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 859 bytes --]
next prev parent reply other threads:[~2015-10-26 23:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 6:19 [PATCH] powerpc/eeh: eeh_pci_enable(): fix checking of post-request state Andrew Donnellan
2015-10-24 1:23 ` Gavin Shan
2015-10-26 23:05 ` Daniel Axtens
2015-10-26 23:09 ` Daniel Axtens [this message]
2016-02-08 11:37 ` Michael Ellerman
2016-02-08 23:57 ` Andrew Donnellan
2016-03-08 7:42 ` Andrew Donnellan
2016-03-08 22:14 ` Gavin Shan
2016-03-09 12:51 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twpdp6qd.fsf@gamma.ozlabs.ibm.com \
--to=dja@axtens.net \
--cc=andrew.donnellan@au1.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).