linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Liu Ping Fan <kernelfans@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/2] powerpc: mm: use macro PGTABLE_EADDR_SIZE instead of digital
Date: Wed, 30 Apr 2014 11:00:39 +0530	[thread overview]
Message-ID: <87tx9bbczk.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1385000275-5988-1-git-send-email-pingfank@linux.vnet.ibm.com>

Liu Ping Fan <kernelfans@gmail.com> writes:

> In case of extending the eaddr in future, use this macro
> PGTABLE_EADDR_SIZE to ease the maintenance of the code.
>
> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>

Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

> ---
>  arch/powerpc/mm/slb_low.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/slb_low.S b/arch/powerpc/mm/slb_low.S
> index 17aa6df..e0b3cf4 100644
> --- a/arch/powerpc/mm/slb_low.S
> +++ b/arch/powerpc/mm/slb_low.S
> @@ -35,7 +35,7 @@ _GLOBAL(slb_allocate_realmode)
>  	 * check for bad kernel/user address
>  	 * (ea & ~REGION_MASK) >= PGTABLE_RANGE
>  	 */
> -	rldicr. r9,r3,4,(63 - 46 - 4)
> +	rldicr. r9,r3,4,(63 - PGTABLE_EADDR_SIZE - 4)
>  	bne-	8f
>
>  	srdi	r9,r3,60		/* get region */
> -- 
> 1.8.1.4
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

      parent reply	other threads:[~2014-04-30  5:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  2:17 [PATCH 1/2] powerpc: mm: use macro PGTABLE_EADDR_SIZE instead of digital Liu Ping Fan
2013-11-21  2:17 ` [PATCH 2/2] powerpc: mm: change pgtable index size for 64K page Liu Ping Fan
2013-11-21 22:11   ` Paul Mackerras
2013-11-21 23:46     ` Benjamin Herrenschmidt
2013-11-22  2:06       ` Michael Ellerman
2014-04-30  5:30 ` Aneesh Kumar K.V [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx9bbczk.fsf@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=kernelfans@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).