From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp05.au.ibm.com (e23smtp05.au.ibm.com [202.81.31.147]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e23smtp05.au.ibm.com", Issuer "GeoTrust SSL CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 611EB2C00CB for ; Wed, 1 Aug 2012 17:46:00 +1000 (EST) Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 1 Aug 2012 17:45:38 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q717bLIf23789598 for ; Wed, 1 Aug 2012 17:37:26 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q717jkut029058 for ; Wed, 1 Aug 2012 17:45:46 +1000 From: "Aneesh Kumar K.V" To: Paul Mackerras Subject: Re: [PATCH -V5 07/13] arch/powerpc: Make some of the PGTABLE_RANGE dependency explicit In-Reply-To: <20120801051808.GD24014@drongo> References: <1343647339-25576-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1343647339-25576-8-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20120801051808.GD24014@drongo> Date: Wed, 01 Aug 2012 13:15:39 +0530 Message-ID: <87txwnhx7g.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Paul Mackerras writes: > On Mon, Jul 30, 2012 at 04:52:13PM +0530, Aneesh Kumar K.V wrote: >> From: "Aneesh Kumar K.V" >> >> slice array size and slice mask size depend on PGTABLE_RANGE. We >> can't directly include pgtable.h in these header because there is >> a circular dependency. So add compile time check for these values. >> >> Signed-off-by: Aneesh Kumar K.V > > Reviewed-by: Paul Mackerras > > but you might like to change: > >> +#define SLICE_MASK_SIZE (PGTABLE_RANG >> 43) > > to have PGTABLE_RANGE rather than PGTABLE_RANG. Updated Thanks, -aneesh