From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: Narayana Murty N <nnmlinux@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, mahesh@linux.ibm.com, oohall@gmail.com,
npiggin@gmail.com, christophe.leroy@csgroup.eu,
maddy@linux.ibm.com, naveen@kernel.org, vaibhav@linux.ibm.com,
ganeshgr@linux.ibm.com, sbhat@linux.ibm.com
Subject: Re: [PATCH v3] powerpc/pseries/eeh: Fix get PE state translation
Date: Sat, 14 Dec 2024 16:58:12 +0530 [thread overview]
Message-ID: <87v7vm8pwz.fsf@gmail.com> (raw)
In-Reply-To: <20241213091822.3641-1-nnmlinux@linux.ibm.com>
Narayana Murty N <nnmlinux@linux.ibm.com> writes:
> The PE Reset State "0" obtained from RTAS calls
> ibm_read_slot_reset_[state|state2] indicates that
> the Reset is deactivated and the PE is not in the MMIO
> Stopped or DMA Stopped state.
>
> With PE Reset State "0", the MMIO and DMA is allowed for
> the PE. The function pseries_eeh_get_state() is currently
> not indicating that to the caller because of which the
> drivers are unable to resume the MMIO and DMA activity.
> The patch fixes that by reflecting what is actually allowed.
>
> Fixes: 00ba05a12b3c ("powerpc/pseries: Cleanup on pseries_eeh_get_state()")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Narayana Murty N <nnmlinux@linux.ibm.com>
>
> ---
> Changelog:
> V1:https://lore.kernel.org/all/20241107042027.338065-1-nnmlinux@linux.ibm.com/
As discussed in v1, powernv already does this and this is needed for
pseries as well for the callers to know, whether the eeh recovery is
completed.
This looks good to me. Please feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
-ritesh
prev parent reply other threads:[~2024-12-14 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 9:18 [PATCH v3] powerpc/pseries/eeh: Fix get PE state translation Narayana Murty N
2024-12-14 11:28 ` Ritesh Harjani (IBM) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7vm8pwz.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=ganeshgr@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mahesh@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=nnmlinux@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=sbhat@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).