[PATCH v3 0/3] memory: fsl_ifc: Make FSL_IFC config visible and selectable

[PATCH v3 0/3] memory: fsl_ifc: Make FSL_IFC config visible and selectable

[Esben Haabendal]

While use of fsl_ifc driver with NAND flash is fine, as the fsl_ifc_nand
driver selects FSL_IFC automatically, we need the CONFIG_FSL_IFC option to
be selectable for platforms using fsl_ifc with NOR flash.

Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")

Changes in v3:
- Refresh arm64 defconfig.
- Link to v2: https://lore.kernel.org/r/20240528-fsl-ifc-config-v2-0-5fd7be76650d@geanix.com

Changes in v2:
- CONFIG_MTD_NAND_FSL_IFC depends on CONFIG_FSL_IFC instead of select.
- Refresh powerpc config snippet accordingly.
- Link to v1: https://lore.kernel.org/r/20240523-fsl-ifc-config-v1-1-6eff73bdc7e6@geanix.com

Signed-off-by: Esben Haabendal <esben@geanix.com>
---
Esben Haabendal (3):
      memory: fsl_ifc: Make FSL_IFC config visible and selectable
      powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC
      arm64/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

 arch/arm64/configs/defconfig        | 1 +
 arch/powerpc/configs/85xx-hw.config | 2 ++
 drivers/memory/Kconfig              | 2 +-
 drivers/mtd/nand/raw/Kconfig        | 3 +--
 4 files changed, 5 insertions(+), 3 deletions(-)
---
base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
change-id: 20240523-fsl-ifc-config-c877902b297e

Best regards,
-- 
Esben Haabendal <esben@geanix.com>

[PATCH v3 1/3] memory: fsl_ifc: Make FSL_IFC config visible and selectable

[Esben Haabendal]

While use of fsl_ifc driver with NAND flash is fine, as the fsl_ifc_nand
driver selects FSL_IFC automatically, we need the CONFIG_FSL_IFC option to
be selectable for platforms using fsl_ifc with NOR flash.

Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Esben Haabendal <esben@geanix.com>
---
 drivers/memory/Kconfig       | 2 +-
 drivers/mtd/nand/raw/Kconfig | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 8efdd1f97139..c82d8d8a16ea 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -167,7 +167,7 @@ config FSL_CORENET_CF
 	  represents a coherency violation.
 
 config FSL_IFC
-	bool "Freescale IFC driver" if COMPILE_TEST
+	bool "Freescale IFC driver"
 	depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST
 	depends on HAS_IOMEM
 
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index cbf8ae85e1ae..614257308516 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -234,8 +234,7 @@ config MTD_NAND_FSL_IFC
 	tristate "Freescale IFC NAND controller"
 	depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST
 	depends on HAS_IOMEM
-	select FSL_IFC
-	select MEMORY
+	depends on FSL_IFC
 	help
 	  Various Freescale chips e.g P1010, include a NAND Flash machine
 	  with built-in hardware ECC capabilities.

-- 
2.45.1

[PATCH v3 2/3] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

[Esben Haabendal]

With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
selected in defconfigs.

Signed-off-by: Esben Haabendal <esben@geanix.com>
---
 arch/powerpc/configs/85xx-hw.config | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/configs/85xx-hw.config b/arch/powerpc/configs/85xx-hw.config
index 524db76f47b7..8aff83217397 100644
--- a/arch/powerpc/configs/85xx-hw.config
+++ b/arch/powerpc/configs/85xx-hw.config
@@ -24,6 +24,7 @@ CONFIG_FS_ENET=y
 CONFIG_FSL_CORENET_CF=y
 CONFIG_FSL_DMA=y
 CONFIG_FSL_HV_MANAGER=y
+CONFIG_FSL_IFC=y
 CONFIG_FSL_PQ_MDIO=y
 CONFIG_FSL_RIO=y
 CONFIG_FSL_XGMAC_MDIO=y
@@ -58,6 +59,7 @@ CONFIG_INPUT_FF_MEMLESS=m
 CONFIG_MARVELL_PHY=y
 CONFIG_MDIO_BUS_MUX_GPIO=y
 CONFIG_MDIO_BUS_MUX_MMIOREG=y
+CONFIG_MEMORY=y
 CONFIG_MMC_SDHCI_OF_ESDHC=y
 CONFIG_MMC_SDHCI_PLTFM=y
 CONFIG_MMC_SDHCI=y

-- 
2.45.1

[PATCH v3 3/3] arm64/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

[Esben Haabendal]

With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
selected in defconfig.

Signed-off-by: Esben Haabendal <esben@geanix.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 2c30d617e180..d101593c3be2 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1429,6 +1429,7 @@ CONFIG_ARM_MEDIATEK_CCI_DEVFREQ=m
 CONFIG_EXTCON_PTN5150=m
 CONFIG_EXTCON_USB_GPIO=y
 CONFIG_EXTCON_USBC_CROS_EC=y
+CONFIG_FSL_IFC=y
 CONFIG_RENESAS_RPCIF=m
 CONFIG_IIO=y
 CONFIG_EXYNOS_ADC=y

-- 
2.45.1

Re: (subset) [PATCH v3 1/3] memory: fsl_ifc: Make FSL_IFC config visible and selectable

[Krzysztof Kozlowski]

On Thu, 30 May 2024 16:46:36 +0200, Esben Haabendal wrote:
> While use of fsl_ifc driver with NAND flash is fine, as the fsl_ifc_nand
> driver selects FSL_IFC automatically, we need the CONFIG_FSL_IFC option to
> be selectable for platforms using fsl_ifc with NOR flash.
> 
> 

Applied first patch only, because:
1. I did not get acks for the defconfigs,
2. I do not consider stable defconfig as a hard-bisectability requirment, thus
it can break within one release as long as next is not affected.

The last statement is kind of not true, because next is now affected, so,
Esben, I think you should resend the defconfigs to respective platform
maintainers. To recall: arm64 goes via your SoC subarch/platform maintainers,
not arm64 maintainers.

Applied, thanks!

[1/3] memory: fsl_ifc: Make FSL_IFC config visible and selectable
      https://git.kernel.org/krzk/linux-mem-ctrl/c/9ba0cae3cac07c21c583f9ff194f74043f90d29c

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH v3 2/3] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

[Krzysztof Kozlowski]

On 30/05/2024 16:46, Esben Haabendal wrote:
> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
> selected in defconfigs.
> 
> Signed-off-by: Esben Haabendal <esben@geanix.com>

Anyone is going to pick this up?

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v3 3/3] arm64/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

[Krzysztof Kozlowski]

On 30/05/2024 16:46, Esben Haabendal wrote:
> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
> selected in defconfig.
> 
> Signed-off-by: Esben Haabendal <esben@geanix.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v3 2/3] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

[Michael Ellerman]

Krzysztof Kozlowski <krzk@kernel.org> writes:
> On 30/05/2024 16:46, Esben Haabendal wrote:
>> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
>> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
>> selected in defconfigs.
>> 
>> Signed-off-by: Esben Haabendal <esben@geanix.com>
>
> Anyone is going to pick this up?

Doesn't it need to be merged along with patch 1?

cheers

Re: [PATCH v3 2/3] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

[Krzysztof Kozlowski]

On 02/07/2024 14:01, Michael Ellerman wrote:
> Krzysztof Kozlowski <krzk@kernel.org> writes:
>> On 30/05/2024 16:46, Esben Haabendal wrote:
>>> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
>>> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
>>> selected in defconfigs.
>>>
>>> Signed-off-by: Esben Haabendal <esben@geanix.com>
>>
>> Anyone is going to pick this up?
> 
> Doesn't it need to be merged along with patch 1?

Well, it's late to talk about this... I replied 3 weeks ago, when taking
the first patch, that I don't consider defconfig as a guaranteed feature
thus no hard-bisectability requirement. Three weeks and no comments on
that, so no, this does not have to be merged with patch 1.

The best if it goes the same cycle, though. So for v6.11.

Best regards,
Krzysztof

Re: [PATCH v3 0/3] memory: fsl_ifc: Make FSL_IFC config visible and selectable

[Michael Ellerman]

On Thu, 30 May 2024 16:46:35 +0200, Esben Haabendal wrote:
> While use of fsl_ifc driver with NAND flash is fine, as the fsl_ifc_nand
> driver selects FSL_IFC automatically, we need the CONFIG_FSL_IFC option to
> be selectable for platforms using fsl_ifc with NOR flash.
> 
> Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
> 
> Changes in v3:
> - Refresh arm64 defconfig.
> - Link to v2: https://lore.kernel.org/r/20240528-fsl-ifc-config-v2-0-5fd7be76650d@geanix.com
> 
> [...]

Patch 2 applied to powerpc/next.

[2/3] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC
      https://git.kernel.org/powerpc/c/45547a0a93d85f704b49788cde2e1d9ab9cd363b

cheers