From: Michael Ellerman <mpe@ellerman.id.au>
To: Ritesh Harjani <ritesh.list@gmail.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: atrajeev@linux.vnet.ibm.com, kjain@linux.ibm.com,
npiggin@gmail.com, Madhavan Srinivasan <maddy@linux.ibm.com>,
christophe.leroy@csgroup.eu, naveen.n.rao@linux.ibm.com,
disgoel@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/3] powerpc/pseries: Export hardware trace macro dump via debugfs
Date: Wed, 26 Jun 2024 18:12:17 +1000 [thread overview]
Message-ID: <87v81wp1ge.fsf@mail.lhotse> (raw)
In-Reply-To: <87msnd5st9.fsf@gmail.com>
Ritesh Harjani (IBM) <ritesh.list@gmail.com> writes:
> This is a generic review and I haven't looked into the PAPR spec for
> htmdump hcall and it's interface.
>
> Madhavan Srinivasan <maddy@linux.ibm.com> writes:
...
>> +
>> + debugfs_create_u32("nodeindex", 0600,
>> + htmdump_debugfs_dir, &nodeindex);
>> + debugfs_create_u32("nodalchipindex", 0600,
>> + htmdump_debugfs_dir, &nodalchipindex);
>> + debugfs_create_u32("coreindexonchip", 0600,
>> + htmdump_debugfs_dir, &coreindexonchip);
>> + debugfs_create_u32("htmtype", 0600,
>> + htmdump_debugfs_dir, &htmtype);
>
> minor nit: For all of the above. S_IRUSR | S_IWUSR instead of 0600.
>
>> + debugfs_create_file("trace", 0400, htmdump_debugfs_dir, ent, &htmdump_fops);
>
> maybe S_IRUSR instead of 0400.
Actually we prefer the octal values, see:
https://git.kernel.org/torvalds/c/57ad583f2086d55ada284c54bfc440123cf73964
cheers
next prev parent reply other threads:[~2024-06-26 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 17:46 [PATCH 1/3] powerpc/pseries: Macros and wrapper functions for H_HTM call Madhavan Srinivasan
2024-06-20 17:46 ` [PATCH 2/3] powerpc/pseries: Export hardware trace macro dump via debugfs Madhavan Srinivasan
2024-06-22 7:40 ` Ritesh Harjani
2024-06-26 3:51 ` Madhavan Srinivasan
2024-06-26 8:12 ` Michael Ellerman [this message]
2024-06-26 0:58 ` kernel test robot
2024-06-20 17:46 ` [PATCH 3/3] powerpc: Document details on H_HTM hcall Madhavan Srinivasan
2024-06-22 8:27 ` Ritesh Harjani
2024-06-26 3:55 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v81wp1ge.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=disgoel@linux.vnet.ibm.com \
--cc=kjain@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).