From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/9] powerpc/47x: Split ppc47x machine in two
Date: Thu, 16 Feb 2023 08:58:35 +1100 [thread overview]
Message-ID: <87v8k2616c.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <ae59e5bec0293b09a1e31690570cd1347b2d6fa6.1676465585.git.christophe.leroy@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> This machine matches two compatibles and sets .pci_irq_fixup
> on one of them.
>
> Split it into two machines, then the probe function can be dropped.
That will break the machine initcalls that look for ppc47x:
arch/powerpc/platforms/44x/ppc476.c:machine_device_initcall(ppc47x, ppc47x_device_probe);
arch/powerpc/platforms/44x/ppc476.c:machine_arch_initcall(ppc47x, ppc47x_get_board_rev);
It still compiles, because of the weak attribute in machine_is(), but
those initcalls will never match and so never run.
cheers
next prev parent reply other threads:[~2023-02-15 21:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 12:53 [PATCH v1 1/9] powerpc/machdep: Define 'compatible' property in ppc_md and use it Christophe Leroy
2023-02-15 12:53 ` [PATCH v1 2/9] powerpc/platforms: Use 'compatible' property for simple cases Christophe Leroy
2023-02-15 12:53 ` [PATCH v1 3/9] powerpc/47x: Split ppc47x machine in two Christophe Leroy
2023-02-15 21:58 ` Michael Ellerman [this message]
2023-02-15 12:53 ` [PATCH v1 4/9] powerpc/gamecube|wii : Use machine_device_initcall() Christophe Leroy
2023-02-15 12:53 ` [PATCH v1 5/9] powerpc/85xx: Fix function naming for p1023_rdb platform Christophe Leroy
2023-02-15 12:53 ` [PATCH v1 6/9] powerpc: Make generic_calibrate_decr() the default Christophe Leroy
2023-02-15 12:53 ` [PATCH v1 7/9] powerpc: Add ppc_md_progress() Christophe Leroy
2023-02-15 12:53 ` [PATCH v1 8/9] powerpc: Use ppc_md_progress() Christophe Leroy
2023-02-15 12:53 ` [PATCH v1 9/9] powerpc/85xx: Don't check ppc_md.progress in mpc85xx_cds_setup_arch() Christophe Leroy
2023-02-15 18:44 ` [PATCH v1 1/9] powerpc/machdep: Define 'compatible' property in ppc_md and use it Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8k2616c.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).