From: Michael Ellerman <mpe@ellerman.id.au>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/macintosh: Use true for boolean value
Date: Wed, 24 Jan 2018 11:47:02 +1100 [thread overview]
Message-ID: <87vafsulq1.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180123174349.GA19627@embeddedgus>
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/macintosh/windfarm_pm72.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This seems to be common across all those drivers. Can you please send
one patch to fix them all to use bool:
$ git grep "started = " drivers/macintosh/
drivers/macintosh/therm_adt746x.c: int started = 0;
drivers/macintosh/therm_adt746x.c: started = 1;
drivers/macintosh/windfarm_pm112.c: slots_started = 1;
drivers/macintosh/windfarm_pm112.c: started = 1;
drivers/macintosh/windfarm_pm121.c: pm121_started = 1;
drivers/macintosh/windfarm_pm72.c: started = 1;
drivers/macintosh/windfarm_pm81.c: wf_smu_started = 1;
drivers/macintosh/windfarm_pm91.c: wf_smu_started = 1;
drivers/macintosh/windfarm_rm31.c: started = 1;
cheers
next prev parent reply other threads:[~2018-01-24 0:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 17:43 [PATCH] drivers/macintosh: Use true for boolean value Gustavo A. R. Silva
2018-01-24 0:47 ` Michael Ellerman [this message]
2018-01-24 0:57 ` Gustavo A. R. Silva
2018-01-24 1:50 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vafsulq1.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=garsilva@embeddedor.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox