From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5DE342C00A0 for ; Fri, 17 Jan 2014 17:57:37 +1100 (EST) Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 Jan 2014 16:57:36 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id C0E383578023 for ; Fri, 17 Jan 2014 17:57:34 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0H6vLDR10158398 for ; Fri, 17 Jan 2014 17:57:22 +1100 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0H6vYfI010323 for ; Fri, 17 Jan 2014 17:57:34 +1100 From: "Aneesh Kumar K.V" To: Li Zhong , PowerPC email list Subject: Re: [RFC PATCH powerpc] Fix compile error of pgtable-ppc64.h In-Reply-To: <1389939036.3000.7.camel@ThinkPad-T5421.cn.ibm.com> References: <1389939036.3000.7.camel@ThinkPad-T5421.cn.ibm.com> Date: Fri, 17 Jan 2014 12:27:30 +0530 Message-ID: <87vbxj6qp1.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Cc: Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Li Zhong writes: > It seems that forward declaration couldn't work well with typedef, use > struct spinlock directly to avoiding following build errors: > > In file included from include/linux/spinlock.h:81, > from include/linux/seqlock.h:35, > from include/linux/time.h:5, > from include/uapi/linux/timex.h:56, > from include/linux/timex.h:56, > from include/linux/sched.h:17, > from arch/powerpc/kernel/asm-offsets.c:17: > include/linux/spinlock_types.h:76: error: redefinition of typedef 'spinlock_t' > /root/linux-next/arch/powerpc/include/asm/pgtable-ppc64.h:563: note: previous declaration of 'spinlock_t' was here > what compiler version ? I have seen that error in gcc 4.3 and it was concluded that it is too old a compiler version to worry about. That specific compiler version also gave error for forward declaring struct; > Signed-off-by: Li Zhong > --- > arch/powerpc/include/asm/pgtable-ppc64.h | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/include/asm/pgtable-ppc64.h b/arch/powerpc/include/asm/pgtable-ppc64.h > index d27960c..bc141c9 100644 > --- a/arch/powerpc/include/asm/pgtable-ppc64.h > +++ b/arch/powerpc/include/asm/pgtable-ppc64.h > @@ -560,9 +560,9 @@ extern void pmdp_invalidate(struct vm_area_struct *vma, unsigned long address, > pmd_t *pmdp); > > #define pmd_move_must_withdraw pmd_move_must_withdraw > -typedef struct spinlock spinlock_t; > -static inline int pmd_move_must_withdraw(spinlock_t *new_pmd_ptl, > - spinlock_t *old_pmd_ptl) > +struct spinlock; > +static inline int pmd_move_must_withdraw(struct spinlock *new_pmd_ptl, > + struct spinlock *old_pmd_ptl) > { > /* > * Archs like ppc64 use pgtable to store per pmd