From: Thomas Gleixner <tglx@linutronix.de>
To: Bitao Hu <yaoma@linux.alibaba.com>,
Doug Anderson <dianders@chromium.org>
Cc: pmladek@suse.com, tsbogend@alpha.franken.de,
linux-parisc@vger.kernel.org, jan.kiszka@siemens.com,
deller@gmx.de, liusong@linux.alibaba.com, npiggin@gmail.com,
linux-kernel@vger.kernel.org,
James.Bottomley@hansenpartnership.com, yaoma@linux.alibaba.com,
kernelfans@gmail.com, akpm@linux-foundation.org,
linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCHv11 2/4] genirq: Provide a snapshot mechanism for interrupt statistics
Date: Mon, 04 Mar 2024 15:24:39 +0100 [thread overview]
Message-ID: <87wmqiulaw.ffs@tglx> (raw)
In-Reply-To: <3a89fafb-f62e-472f-b40b-8bf97954e9e3@linux.alibaba.com>
On Mon, Mar 04 2024 at 20:00, Bitao Hu wrote:
>> +# Snapshot for interrupt statistics
>> +config GENERIC_IRQ_STAT_SNAPSHOT
>> + bool
>> +
>> # Support forced irq threading
>> config IRQ_FORCED_THREADING
>> bool
>
> I think we should follow Douglas's suggestion by making
> "config GENERIC_IRQ_STAT_SNAPSHOT" automatically selectable by
> "config SOFTLOCKUP_DETECTOR_INTR_STORM". This can prevent users
> from inadvertently disabling "config GENERIC_IRQ_STAT_SNAPSHOT"
> while enabling "config SOFTLOCKUP_DETECTOR_INTR_STORM".
The above is not even configurable by the user. It's only selectable by
some other config option.
> +# Snapshot for interrupt statistics
> +config GENERIC_IRQ_STAT_SNAPSHOT
> + bool
> + help
> +
> + Say Y here to enable the kernel to provide a snapshot mechanism
> + for interrupt statistics.
That makes is visible which is pointless because it's only relevant when
there is an actual user.
Thanks,
tglx
next prev parent reply other threads:[~2024-03-04 14:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 7:22 [PATCHv11 0/4] *** Detect interrupt storm in softlockup *** Bitao Hu
2024-02-28 7:22 ` [PATCHv11 1/4] watchdog/softlockup: low-overhead detection of interrupt storm Bitao Hu
2024-02-28 7:22 ` [PATCHv11 2/4] genirq: Provide a snapshot mechanism for interrupt statistics Bitao Hu
2024-02-28 22:44 ` Doug Anderson
2024-03-01 19:22 ` Thomas Gleixner
2024-03-04 12:00 ` Bitao Hu
2024-03-04 14:24 ` Thomas Gleixner [this message]
2024-03-05 10:57 ` Bitao Hu
2024-03-05 16:57 ` Thomas Gleixner
2024-03-06 11:09 ` Bitao Hu
2024-02-28 7:22 ` [PATCHv11 3/4] genirq: Avoid summation loops for /proc/interrupts Bitao Hu
2024-02-28 22:44 ` Doug Anderson
2024-02-28 7:22 ` [PATCHv11 4/4] watchdog/softlockup: report the most frequent interrupts Bitao Hu
2024-02-28 22:44 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmqiulaw.ffs@tglx \
--to=tglx@linutronix.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=dianders@chromium.org \
--cc=jan.kiszka@siemens.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liusong@linux.alibaba.com \
--cc=npiggin@gmail.com \
--cc=pmladek@suse.com \
--cc=tsbogend@alpha.franken.de \
--cc=yaoma@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).