From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A07BBC77B7F for ; Fri, 12 May 2023 04:37:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QHbbj5tBQz3fZH for ; Fri, 12 May 2023 14:37:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=qrQabGj5; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QHbZl6YhLz3c4B for ; Fri, 12 May 2023 14:37:03 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=qrQabGj5; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QHbZl5J04z4wgv; Fri, 12 May 2023 14:37:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1683866223; bh=bFdF3qVgrRQwTQKB2U2Zclw0g6ascaQQQ/vCod6HYPI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qrQabGj51hz+dz3GgYO48fUDv3SpvtZ3BBIFG/OsDWeKuqaxFtQoyBD2HNLaAO30u 8JEsuAvf8rqTc2mLlGhgKvCsO0Zb0xeHIhZSNJ7iQMrKT1gXJD+KbB3IRBVlKrO6u3 EKyjd1iDbvy85BfrTNvBDHngrc4A+poGervWfhQgxpSpoNkI0ut/Mjl+DfgiZDjTV3 vsjGyBr3hA0dznhnnn0GM6l9+Vz14j9enBbsZavd2fVrtQQOsDVrNSQo1eM6ykmGAh QT3unhjiZ+9kEOL7jsOfDTPqmSsUTo69exBDUPtuXy2V2Y+BUOaZpQkm0iHGHgkCuN nPeeVACZuosxg== From: Michael Ellerman To: Randy Dunlap , linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/embedded6xx: select MPC10X_BRIDGE only if PCI is set In-Reply-To: <20230505230032.19156-1-rdunlap@infradead.org> References: <20230505230032.19156-1-rdunlap@infradead.org> Date: Fri, 12 May 2023 14:37:03 +1000 Message-ID: <87wn1ejhcg.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Randy Dunlap , linuxppc-dev@lists.ozlabs.org, Nicholas Piggin Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Randy Dunlap writes: > When CONFIG_SMP is not set, CONFIG_BROKEN_ON_SMP is set, and > CONFIG_PCI is not set, there can be a kconfig warning: > > WARNING: unmet direct dependencies detected for PPC_INDIRECT_PCI > Depends on [n]: PCI [=n] > Selected by [y]: > - MPC10X_BRIDGE [=y] > > To fix that, make the selects of MPC10X_BRIDGE be conditional > on PCI. That would work, but using "imply" would be preferable as it doesn't have to encode anything about the PCI dependency. cheers