LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: "Michal Suchanek" <msuchanek@suse.de>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Philippe Ombredanne" <pombredanne@nexb.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Thomas Falcon" <tlfalcon@linux.vnet.ibm.com>,
	"Michal Suchanek" <msuchanek@suse.de>,
	"Tobin C. Harding" <me@tobin.cc>,
	"Michael Neuling" <mikey@neuling.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h
Date: Tue, 16 Jan 2018 14:16:58 +1100	[thread overview]
Message-ID: <87wp0ia3x1.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180115133003.3447-1-msuchanek@suse.de>

Michal Suchanek <msuchanek@suse.de> writes:

> Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings") uses u64 in asm/hvcall.h without including linux/types.h
>
> This breaks hvcall.h users that do not include the header themselves.
>
> Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
>     settings")
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>  arch/powerpc/include/asm/hvcall.h | 1 +
>  1 file changed, 1 insertion(+)

Thanks. None of my ~250 defconfig test builds hit this, what config are
you using?

cheers

> diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
> index f0461618bf7b..eca3f9c68907 100644
> --- a/arch/powerpc/include/asm/hvcall.h
> +++ b/arch/powerpc/include/asm/hvcall.h
> @@ -353,6 +353,7 @@
>  #define PROC_TABLE_GTSE		0x01
>  
>  #ifndef __ASSEMBLY__
> +#include <linux/types.h>
>  
>  /**
>   * plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments
> -- 
> 2.13.6

  reply	other threads:[~2018-01-16  3:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 13:30 [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h Michal Suchanek
2018-01-16  3:16 ` Michael Ellerman [this message]
2018-01-16  4:53   ` David Gibson
2018-01-17 13:25 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp0ia3x1.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=me@tobin.cc \
    --cc=mikey@neuling.org \
    --cc=msuchanek@suse.de \
    --cc=paulus@samba.org \
    --cc=pombredanne@nexb.com \
    --cc=tlfalcon@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox