From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54BF5C31D97 for ; Thu, 4 Jul 2024 12:33:09 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=eC9J/ndt; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WFGJg6mZ8z3flv for ; Thu, 4 Jul 2024 22:33:07 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=eC9J/ndt; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WFGHw3FkZz30W8 for ; Thu, 4 Jul 2024 22:32:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1720096348; bh=Kg76KaOIbqnAt68SmtPouOnB34EHvYcOG9w3BrvhJDM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=eC9J/ndtD3JZYC5bXcIUuL9baGS+FEO9OPeVGtvMcAfVWSbN1jia1Em79xmhsbey1 ix9jF1OFtfcOlZ/PsqE/Cvdjd8DLaWVIBdk7XuVWxnJoX2/CWaCi5AkFef0js7DppK OC3c5wY7L7QYjUDAEc6m9bBbylPc/VqSre7llqaC2XyjUOi+CBaaUqaUmWFNRlOpUz 0ML8tWrrT5/3TQOqY0c4e9+cb8ag/vk/IqVx5siUeoR33KgCPUaRrvakLHSmPIRUQT phQdAm+PVhNIF9AIn6IEESqQLrzgtxLQyggahFovqM4i3jtiA8bOPJTHCJeF4HNGcm HfMLzR0cSNYhQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4WFGHt5Rmjz4wbp; Thu, 4 Jul 2024 22:32:26 +1000 (AEST) From: Michael Ellerman To: Jeff Johnson , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Scott Wood , Arnd Bergmann , Jeremy Kerr Subject: Re: [PATCH] powerpc: add missing MODULE_DESCRIPTION() macros In-Reply-To: <2509b43d-630c-4295-8330-5976677bf8bc@quicinc.com> References: <20240615-md-powerpc-arch-powerpc-v1-1-ba4956bea47a@quicinc.com> <2509b43d-630c-4295-8330-5976677bf8bc@quicinc.com> Date: Thu, 04 Jul 2024 22:32:26 +1000 Message-ID: <87y16hibhh.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Jeff Johnson writes: > On 6/15/2024 10:06 AM, Jeff Johnson wrote: >> With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/kernel/rtas_flash.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/sysdev/rtc_cmos_setup.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/platforms/pseries/papr_scm.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/platforms/cell/spufs/spufs.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/platforms/cell/cbe_thermal.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/platforms/cell/cpufreq_spudemand.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/platforms/cell/cbe_powerbutton.o >> >> Add the missing invocation of the MODULE_DESCRIPTION() macro to all >> files which have a MODULE_LICENSE(). >> >> This includes 85xx/t1042rdb_diu.c and chrp/nvram.c which, although >> they did not produce a warning with the powerpc allmodconfig >> configuration, may cause this warning with other configurations. >> >> Signed-off-by: Jeff Johnson >> --- >> Corrections to these descriptions are welcomed. I'm not an expert in >> this code so in most cases I've taken these descriptions directly from >> code comments, Kconfig descriptions, or git logs. History has shown >> that in some cases these are originally wrong due to cut-n-paste >> errors, and in other cases the drivers have evolved such that the >> original information is no longer accurate. ... > > Following up to see if anything else is needed from me. Hoping to see this in > linux-next so I can remove it from my tracking spreadsheet :) I have this in my test branch, it will appear in linux-next next week. A spreadsheet seems like overkill ;) cheers