* [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler
@ 2024-04-05 19:31 Nathan Chancellor
2024-04-05 19:57 ` Justin Stitt
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Nathan Chancellor @ 2024-04-05 19:31 UTC (permalink / raw)
To: mpe
Cc: justinstitt, ajd, llvm, patches, Nathan Chancellor, morbo, bgray,
linuxppc-dev
When building with LLVM_IAS=1, there is an error because
'-fatal-warnings' is not recognized as a valid flag:
clang: error: unsupported argument '-fatal-warnings' to option '-Wa,'
Use the double hyphen version of the flag, '--fatal-warnings', which
works with both the GNU assembler and LLVM's integrated assembler.
Fixes: 608d4a5ca563 ("powerpc: Error on assembly warnings")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
arch/powerpc/Kbuild | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/Kbuild b/arch/powerpc/Kbuild
index da862e9558bc..571f260b0842 100644
--- a/arch/powerpc/Kbuild
+++ b/arch/powerpc/Kbuild
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0
-subdir-ccflags-$(CONFIG_PPC_WERROR) := -Werror -Wa,-fatal-warnings
-subdir-asflags-$(CONFIG_PPC_WERROR) := -Wa,-fatal-warnings
+subdir-ccflags-$(CONFIG_PPC_WERROR) := -Werror -Wa,--fatal-warnings
+subdir-asflags-$(CONFIG_PPC_WERROR) := -Wa,--fatal-warnings
obj-y += kernel/
obj-y += mm/
---
base-commit: bfe51886ca544956eb4ff924d1937ac01d0ca9c8
change-id: 20240405-ppc-fix-wa-fatal-warnings-clang-603f0ebb0133
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler
2024-04-05 19:31 [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler Nathan Chancellor
@ 2024-04-05 19:57 ` Justin Stitt
2024-04-09 8:57 ` Michael Ellerman
2024-04-22 8:16 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Justin Stitt @ 2024-04-05 19:57 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: ajd, llvm, patches, morbo, bgray, linuxppc-dev
On Fri, Apr 5, 2024 at 12:31 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> When building with LLVM_IAS=1, there is an error because
> '-fatal-warnings' is not recognized as a valid flag:
>
> clang: error: unsupported argument '-fatal-warnings' to option '-Wa,'
>
> Use the double hyphen version of the flag, '--fatal-warnings', which
> works with both the GNU assembler and LLVM's integrated assembler.
>
> Fixes: 608d4a5ca563 ("powerpc: Error on assembly warnings")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Nice catch.
Reviewed-by: Justin Stitt <justinstitt@google.com>
> ---
> arch/powerpc/Kbuild | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/Kbuild b/arch/powerpc/Kbuild
> index da862e9558bc..571f260b0842 100644
> --- a/arch/powerpc/Kbuild
> +++ b/arch/powerpc/Kbuild
> @@ -1,6 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0
> -subdir-ccflags-$(CONFIG_PPC_WERROR) := -Werror -Wa,-fatal-warnings
> -subdir-asflags-$(CONFIG_PPC_WERROR) := -Wa,-fatal-warnings
> +subdir-ccflags-$(CONFIG_PPC_WERROR) := -Werror -Wa,--fatal-warnings
> +subdir-asflags-$(CONFIG_PPC_WERROR) := -Wa,--fatal-warnings
>
> obj-y += kernel/
> obj-y += mm/
>
> ---
> base-commit: bfe51886ca544956eb4ff924d1937ac01d0ca9c8
> change-id: 20240405-ppc-fix-wa-fatal-warnings-clang-603f0ebb0133
>
> Best regards,
> --
> Nathan Chancellor <nathan@kernel.org>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler
2024-04-05 19:31 [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler Nathan Chancellor
2024-04-05 19:57 ` Justin Stitt
@ 2024-04-09 8:57 ` Michael Ellerman
2024-04-22 8:16 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2024-04-09 8:57 UTC (permalink / raw)
To: Nathan Chancellor
Cc: justinstitt, ajd, llvm, patches, Nathan Chancellor, morbo, bgray,
linuxppc-dev
Nathan Chancellor <nathan@kernel.org> writes:
> When building with LLVM_IAS=1, there is an error because
> '-fatal-warnings' is not recognized as a valid flag:
>
> clang: error: unsupported argument '-fatal-warnings' to option '-Wa,'
>
> Use the double hyphen version of the flag, '--fatal-warnings', which
> works with both the GNU assembler and LLVM's integrated assembler.
>
> Fixes: 608d4a5ca563 ("powerpc: Error on assembly warnings")
Thanks.
I guess I need to do some of my clang builds with LLVM_IAS=1 :}
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler
2024-04-05 19:31 [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler Nathan Chancellor
2024-04-05 19:57 ` Justin Stitt
2024-04-09 8:57 ` Michael Ellerman
@ 2024-04-22 8:16 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2024-04-22 8:16 UTC (permalink / raw)
To: mpe, Nathan Chancellor
Cc: justinstitt, ajd, llvm, patches, morbo, bgray, linuxppc-dev
On Fri, 05 Apr 2024 12:31:22 -0700, Nathan Chancellor wrote:
> When building with LLVM_IAS=1, there is an error because
> '-fatal-warnings' is not recognized as a valid flag:
>
> clang: error: unsupported argument '-fatal-warnings' to option '-Wa,'
>
> Use the double hyphen version of the flag, '--fatal-warnings', which
> works with both the GNU assembler and LLVM's integrated assembler.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc: Fix fatal warnings flag for LLVM's integrated assembler
https://git.kernel.org/powerpc/c/8884fc918f6aee220f9b41806974508bd0213aca
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-22 8:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-05 19:31 [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler Nathan Chancellor
2024-04-05 19:57 ` Justin Stitt
2024-04-09 8:57 ` Michael Ellerman
2024-04-22 8:16 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).