From: Michael Ellerman <mpe@ellerman.id.au>
To: cgel.zte@gmail.com
Cc: Zeal Robot <zealci@zte.com.cn>,
linux-kernel@vger.kernel.org, paulus@samba.org,
ye.guojin@zte.com.cn, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: xmon: remove the duplicated operand of the bitwise operator
Date: Fri, 05 Nov 2021 17:13:35 +1100 [thread overview]
Message-ID: <87y2636sfk.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20211105034011.76008-1-ye.guojin@zte.com.cn>
cgel.zte@gmail.com writes:
> From: Ye Guojin <ye.guojin@zte.com.cn>
>
> The operands of the bitwise OR operator are duplicated, remove one of
> them.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
> ---
> arch/powerpc/xmon/ppc-opc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, but this code is copied from binutils, we don't take cleanup
patches to it.
cheers
> diff --git a/arch/powerpc/xmon/ppc-opc.c b/arch/powerpc/xmon/ppc-opc.c
> index dfb80810b16c..2cab0ec0d162 100644
> --- a/arch/powerpc/xmon/ppc-opc.c
> +++ b/arch/powerpc/xmon/ppc-opc.c
> @@ -6731,9 +6731,9 @@ const struct powerpc_opcode powerpc_opcodes[] = {
> {"fre.", A(63,24,1), AFRALFRC_MASK, POWER5, POWER7|PPCVLE, {FRT, FRB, A_L}},
>
> {"fmul", A(63,25,0), AFRB_MASK, PPCCOM, PPCEFS|PPCVLE, {FRT, FRA, FRC}},
> -{"fm", A(63,25,0), AFRB_MASK, PWRCOM, PPCVLE|PPCVLE, {FRT, FRA, FRC}},
> +{"fm", A(63, 25, 0), AFRB_MASK, PWRCOM, PPCVLE, {FRT, FRA, FRC}},
> {"fmul.", A(63,25,1), AFRB_MASK, PPCCOM, PPCEFS|PPCVLE, {FRT, FRA, FRC}},
> -{"fm.", A(63,25,1), AFRB_MASK, PWRCOM, PPCVLE|PPCVLE, {FRT, FRA, FRC}},
> +{"fm.", A(63, 25, 1), AFRB_MASK, PWRCOM, PPCVLE, {FRT, FRA, FRC}},
>
> {"frsqrte", A(63,26,0), AFRAFRC_MASK, POWER7, PPCVLE, {FRT, FRB}},
> {"frsqrte", A(63,26,0), AFRALFRC_MASK, PPC, POWER7|PPCVLE, {FRT, FRB, A_L}},
> --
> 2.25.1
prev parent reply other threads:[~2021-11-05 6:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 3:40 [PATCH] powerpc: xmon: remove the duplicated operand of the bitwise operator cgel.zte
2021-11-05 6:13 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2636sfk.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=cgel.zte@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=ye.guojin@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox