From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02360C433DB for ; Fri, 26 Mar 2021 05:38:43 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FBFF61A48 for ; Fri, 26 Mar 2021 05:38:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FBFF61A48 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=axtens.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F69kS4ZKTz3c0c for ; Fri, 26 Mar 2021 16:38:40 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.a=rsa-sha256 header.s=google header.b=aiVnRhdX; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=axtens.net (client-ip=2607:f8b0:4864:20::102b; helo=mail-pj1-x102b.google.com; envelope-from=dja@axtens.net; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.a=rsa-sha256 header.s=google header.b=aiVnRhdX; dkim-atps=neutral Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F69jz5D2mz303J for ; Fri, 26 Mar 2021 16:38:13 +1100 (AEDT) Received: by mail-pj1-x102b.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so3718061pjh.1 for ; Thu, 25 Mar 2021 22:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=87Df9w+HLEtQIYbykZK6bC5setLTpy5vdBvKQb+SxG0=; b=aiVnRhdXR8vqYfZs7pR9AAdR+ScJHjfTl952RwX/4aJVw7oHFCSUCBgIrXS5rzdA0G Od/yPxM+UBMZbP9usp1GQ4peMtXL+AnkFzvWqNVQvLvvSSh7aIIXmu77zSVJ6PSsV6GN w3BV/SekzvMkknp+8SOKBVK0jKaYbL9PcwbZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=87Df9w+HLEtQIYbykZK6bC5setLTpy5vdBvKQb+SxG0=; b=szI0xhVJ+06YQuEobmbnNraz9UevWQPbbjrIufh2nTDbq6k7ZbeS9Ms8e9DkCFRufK BAgtj477SvE8Np4EYmMRtBJS78xYZvCGC5rl/7Em8f1CKJzroILJVv+i7m1mFj8Q+VJJ f+wyCv+oHZ6YkIq7e07UvK1M9Zx+bYEiMyfQp21QLDZMVXYr+WOsPWJO/NbTi7lpH4uM gj1uf1+X4rcNGEx/Q13c/UT7eQE9SWkGt3gq8RrWGzE/6j5n7RWOUf2jhlooXH4E0qy7 OiMuBcARgeL5JdLy4kq+9pbkaqD3Ytj+xdIOh7LNrTOa1+fYV9n/PCTJLw0VM20KEmmW dkjg== X-Gm-Message-State: AOAM5304BSqnyj3paRachjRet/rbfRxG2bOaccE4ahP9LlPulowKlEVT dqOYeX1A/PosCVbByZDZXAHiFQ== X-Google-Smtp-Source: ABdhPJyvcXRQyAYpeNoyjsN9TtaOvpteuYOcXzmzRTWnnmi5naQ0BxtrTjUBbMsEaOFtaevNqkz+Bw== X-Received: by 2002:a17:902:c317:b029:e4:aecd:8539 with SMTP id k23-20020a170902c317b02900e4aecd8539mr13673784plx.61.1616737090389; Thu, 25 Mar 2021 22:38:10 -0700 (PDT) Received: from localhost (2001-44b8-111e-5c00-39c5-e677-fdb8-5d64.static.ipv6.internode.on.net. [2001:44b8:111e:5c00:39c5:e677:fdb8:5d64]) by smtp.gmail.com with ESMTPSA id s200sm7803561pfs.53.2021.03.25.22.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 22:38:09 -0700 (PDT) From: Daniel Axtens To: Wan Jiabing , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Nicholas Piggin , "Aneesh Kumar K.V" , =?utf-8?Q?C=C3=A9dric?= Le Goater , Randy Dunlap , Wan Jiabing , Ganesh Goudar , Christophe Leroy , Michal Suchanek , Geert Uytterhoeven , Pingfan Liu , Frederic Weisbecker , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] arch: powerpc: Remove duplicate includes In-Reply-To: <20210323062916.295346-1-wanjiabing@vivo.com> References: <20210323062916.295346-1-wanjiabing@vivo.com> Date: Fri, 26 Mar 2021 16:38:06 +1100 Message-ID: <87y2ea79vl.fsf@linkitivity.dja.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kael_w@yeah.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Wan Jiabing writes: > mmu-hash.h: asm/bug.h has been included at line 12, so remove > the duplicate one at line 21. Looking at the file I had wondered if this was due to a #ifdef being removed, but no, the second one was just added in commit 891121e6c02c ("powerpc/mm: Differentiate between hugetlb and THP during page walk"). How odd! Anyway, all of these look good to me, and the automated checks at http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210323062916.295346-1-wanjiabing@vivo.com/ have all passed. Reviewed-by: Daniel Axtens Kind regards, Daniel