linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: juri.lelli@redhat.com, ego@linux.vnet.ibm.com, pauld@redhat.com,
	parth@linux.ibm.com, Ihor.Pasichnyk@ibm.com,
	linuxppc-dev@ozlabs.org, longman@redhat.com
Subject: Re: [PATCH v5 1/2] powerpc/vcpu: Assume dedicated processors as non-preempt
Date: Fri, 13 Dec 2019 21:06:32 +1100	[thread overview]
Message-ID: <87y2vgo7yv.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20191213050755.GA23839@linux.vnet.ibm.com>

Srikar Dronamraju <srikar@linux.vnet.ibm.com> writes:
> * Michael Ellerman <mpe@ellerman.id.au> [2019-12-13 14:50:35]:
>
>> Waiman Long suggested using static_keys.
>> 
>> Fixes: 247f2f6f3c70 ("sched/core: Don't schedule threads on pre-empted vCPUs")
>> Cc: stable@vger.kernel.org # v4.18+
>> Reported-by: Parth Shah <parth@linux.ibm.com>
>> Reported-by: Ihor Pasichnyk <Ihor.Pasichnyk@ibm.com>
>> Tested-by: Juri Lelli <juri.lelli@redhat.com>
>> Acked-by: Waiman Long <longman@redhat.com>
>> Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
>> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>> Acked-by: Phil Auld <pauld@redhat.com>
>> Reviewed-by: Vaidyanathan Srinivasan <svaidy@linux.ibm.com>
>> Tested-by: Parth Shah <parth@linux.ibm.com>
>> [mpe: Move the key and setting of the key to pseries/setup.c]
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> ---
>>  arch/powerpc/include/asm/spinlock.h    | 4 +++-
>>  arch/powerpc/platforms/pseries/setup.c | 7 +++++++
>>  2 files changed, 10 insertions(+), 1 deletion(-)
>> 
>
> Tested with your version of the patch and its working as expected

Thanks, I took the values below and put them in the changelog for the
patched case.

cheers

> Latency percentiles (usec)
>         50.0th: 45
>         75.0th: 63
>         90.0th: 74
>         95.0th: 78
>         *99.0th: 82
>         99.5th: 83
>         99.9th: 86
>         min=0, max=96
> Latency percentiles (usec)
>         50.0th: 46
>         75.0th: 64
>         90.0th: 75
>         95.0th: 79
>         *99.0th: 83
>         99.5th: 85
>         99.9th: 91
>         min=0, max=117
> Latency percentiles (usec)
>         50.0th: 46
>         75.0th: 64
>         90.0th: 75
>         95.0th: 79
>         *99.0th: 83
>         99.5th: 84
>         99.9th: 90
>         min=0, max=95
> Latency percentiles (usec)
>         50.0th: 47
>         75.0th: 65
>         90.0th: 75
>         95.0th: 79
>         *99.0th: 84
>         99.5th: 85
>         99.9th: 90
>         min=0, max=117
> Latency percentiles (usec)
>         50.0th: 45
>         75.0th: 64
>         90.0th: 75
>         95.0th: 79
>         *99.0th: 82
>         99.5th: 83
>         99.9th: 93
>         min=0, max=111
>
>
> -- 
> Thanks and Regards
> Srikar Dronamraju

  reply	other threads:[~2019-12-13 10:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13  3:50 [PATCH v5 1/2] powerpc/vcpu: Assume dedicated processors as non-preempt Michael Ellerman
2019-12-13  3:50 ` [PATCH v5 2/2] powerpc/shared: Use static key to detect shared processor Michael Ellerman
2019-12-13  5:07 ` [PATCH v5 1/2] powerpc/vcpu: Assume dedicated processors as non-preempt Srikar Dronamraju
2019-12-13 10:06   ` Michael Ellerman [this message]
2019-12-13 21:19 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2vgo7yv.fsf@mpe.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=Ihor.Pasichnyk@ibm.com \
    --cc=ego@linux.vnet.ibm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=longman@redhat.com \
    --cc=parth@linux.ibm.com \
    --cc=pauld@redhat.com \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).