From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41KV4w51vRzF1LK for ; Tue, 3 Jul 2018 13:30:40 +1000 (AEST) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w633SUYG118179 for ; Mon, 2 Jul 2018 23:30:38 -0400 Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) by mx0a-001b2d01.pphosted.com with ESMTP id 2jyt7snbv0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 02 Jul 2018 23:30:37 -0400 Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Jul 2018 21:30:37 -0600 References: <1529979376-7292-1-git-send-email-linuxram@us.ibm.com> <1529979376-7292-3-git-send-email-linuxram@us.ibm.com> From: Thiago Jung Bauermann To: Ram Pai Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, Ulrich.Weigand@de.ibm.com, fweimer@redhat.com, msuchanek@suse.de Subject: Re: [PATCH 1/2] powerpc/core-pkeys: execute-permission on keys are disabled by default In-reply-to: <1529979376-7292-3-git-send-email-linuxram@us.ibm.com> Date: Tue, 03 Jul 2018 00:30:25 -0300 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <87y3etknce.fsf@morokweng.localdomain> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Ram Pai writes: > Only when the key is allocated, its permission are enabled. > > Signed-off-by: Ram Pai > --- > tools/testing/selftests/powerpc/ptrace/core-pkey.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/tools/testing/selftests/powerpc/ptrace/core-pkey.c b/tools/testing/selftests/powerpc/ptrace/core-pkey.c > index 36bc312..b353d86 100644 > --- a/tools/testing/selftests/powerpc/ptrace/core-pkey.c > +++ b/tools/testing/selftests/powerpc/ptrace/core-pkey.c > @@ -140,6 +140,10 @@ static int child(struct shared_info *info) > > if (disable_execute) > info->iamr |= 1ul << pkeyshift(pkey1); > + else > + info->iamr &= ~(1ul << pkeyshift(pkey1)); > + info->iamr &= ~(1ul << pkeyshift(pkey2) | 1ul << pkeyshift(pkey3)); > + > > info->uamor |= 3ul << pkeyshift(pkey1) | 3ul << pkeyshift(pkey2); Reviewed-by: Thiago Jung Bauermann -- Thiago Jung Bauermann IBM Linux Technology Center