From: Michael Ellerman <mpe@ellerman.id.au>
To: Anjali K <anjalik@linux.ibm.com>, Kees Cook <kees@kernel.org>
Cc: npiggin@gmail.com, naveen@kernel.org,
christophe.leroy@csgroup.eu, gustavoars@kernel.org,
linux-hardening@vger.kernel.org, vishalc@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/pseries: Whitelist dtl slub object for copying to userspace
Date: Fri, 21 Jun 2024 21:38:41 +1000 [thread overview]
Message-ID: <87zfrecypq.fsf@mail.lhotse> (raw)
In-Reply-To: <45c38d92-8d7c-466c-833d-0c2aa389eeda@linux.ibm.com>
Anjali K <anjalik@linux.ibm.com> writes:
> Hi Michael
>
> On 18/06/24 12:41, Michael Ellerman wrote:
>> I guess there isn't a kmem_cache_create_user_readonly() ?
> Thank you for your review.
>
> My understanding of the question is whether there's a way to whitelist a
> region such that it can be copied to userspace, but not written to using
> copy_from_user().
Yes that's what I meant, and I pretty much worked that out from looking
at the implementation, but was hoping Kees would tell me it was there
somewhere, or implement it :) Apologies for being cryptic.
> No, we don't have a function to whitelist only for copy_to_user() and not
> copy_from_user().
Yep. I'll take this patch as-is, I think we've established that it's
pretty low risk to whitelist the whole cache.
cheers
next prev parent reply other threads:[~2024-06-21 11:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 17:38 [PATCH] powerpc/pseries: Whitelist dtl slub object for copying to userspace Anjali K
2024-06-17 10:37 ` Srikar Dronamraju
2024-06-17 17:59 ` Kees Cook
2024-06-18 7:11 ` Michael Ellerman
2024-06-21 8:12 ` Anjali K
2024-06-21 11:38 ` Michael Ellerman [this message]
2024-06-20 17:28 ` Anjali K
2024-06-20 18:59 ` Kees Cook
2024-06-24 12:30 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfrecypq.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=anjalik@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=vishalc@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).