From: Michael Ellerman <mpe@ellerman.id.au>
To: mahesh@linux.ibm.com
Cc: Nathan Lynch <nathanl@linux.ibm.com>,
Tyrel Datwyler <tyreld@linux.ibm.com>,
linux-pci <linux-pci@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@ozlabs.org>,
Oliver O'Halloran <oohall@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v8 1/2] powerpc/rtas: Rename rtas_error_rc to rtas_generic_errno
Date: Thu, 17 Aug 2023 16:44:38 +1000 [thread overview]
Message-ID: <87zg2q5fs9.fsf@mail.lhotse> (raw)
In-Reply-To: <xzsx7qc3el674iyy2lsn3adm7j2vh5xj6cjaqxgjm6lwcjiz5u@evoqbrvhqf26>
Mahesh J Salgaonkar <mahesh@linux.ibm.com> writes:
> On 2023-08-15 13:52:14 Tue, Michael Ellerman wrote:
>> Mahesh Salgaonkar <mahesh@linux.ibm.com> writes:
...
>> > diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h
>> > index 3abe15ac79db1..5572a0a2f6e18 100644
>> > --- a/arch/powerpc/include/asm/rtas.h
>> > +++ b/arch/powerpc/include/asm/rtas.h
>> > @@ -202,7 +202,9 @@ typedef struct {
>> > #define RTAS_USER_REGION_SIZE (64 * 1024)
>> >
>> > /* RTAS return status codes */
>> > -#define RTAS_BUSY -2 /* RTAS Busy */
>> > +#define RTAS_HARDWARE_ERROR (-1) /* Hardware Error */
>> > +#define RTAS_BUSY (-2) /* RTAS Busy */
>>
>> Are the brackets necessary?
>
> During v5 changset I received offline review comment to add brackets,
> hence continued here as well. I can take it away if Nathan is fine with
> it.
OK. I can't think of a context where the brackets are useful, but I'm
probably just not thinking hard enough. I don't really mind adding them,
I was just curious what the justification for them was.
cheers
next prev parent reply other threads:[~2023-08-17 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 6:10 [PATCH v8 1/2] powerpc/rtas: Rename rtas_error_rc to rtas_generic_errno Mahesh Salgaonkar
2023-08-07 6:11 ` [PATCH v8 2/2] PCI: rpaphp: Error out on busy status from get-sensor-state Mahesh Salgaonkar
2023-08-15 3:52 ` [PATCH v8 1/2] powerpc/rtas: Rename rtas_error_rc to rtas_generic_errno Michael Ellerman
2023-08-16 16:23 ` Mahesh J Salgaonkar
2023-08-17 6:44 ` Michael Ellerman [this message]
2023-08-17 12:29 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg2q5fs9.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=nathanl@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).