From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Valentin Rothberg <valentinrothberg@gmail.com>
Subject: Re: [PATCH] powerpc/mm/radix: fix STD_MMU_64 typo
Date: Tue, 03 May 2016 14:43:48 +0530 [thread overview]
Message-ID: <87zis7y04z.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <1462258767-83025-1-git-send-email-valentinrothberg@gmail.com>
Valentin Rothberg <valentinrothberg@gmail.com> writes:
> s/MMU_STD_64/STD_MMU_64/
>
> Fixes: 11ffc1cfa4c2 ("powerpc/mm/radix: Use STD_MMU_64 to properly
> isolate hash related code")
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>
> I only compile tested this change. The issue has been detected with
> scripts/checkkconfigsymbols.py
>
> arch/powerpc/kernel/mce_power.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/powerpc/kernel/mce_power.c b/arch/powerpc/kernel/mce_power.c
> index bec70338672e..7353991c4ece 100644
> --- a/arch/powerpc/kernel/mce_power.c
> +++ b/arch/powerpc/kernel/mce_power.c
> @@ -80,7 +80,7 @@ void __flush_tlb_power9(unsigned int action)
>
>
> /* flush SLBs and reload */
> -#ifdef CONFIG_PPC_MMU_STD_64
> +#ifdef CONFIG_PPC_STD_MMU_64
> static void flush_and_reload_slb(void)
> {
> struct slb_shadow *slb;
> @@ -125,7 +125,7 @@ static long mce_handle_derror(uint64_t dsisr, uint64_t slb_error_bits)
> * reset the error bits whenever we handle them so that at the end
> * we can check whether we handled all of them or not.
> * */
> -#ifdef CONFIG_PPC_MMU_STD_64
> +#ifdef CONFIG_PPC_STD_MMU_64
> if (dsisr & slb_error_bits) {
> flush_and_reload_slb();
> /* reset error bits */
> @@ -157,7 +157,7 @@ static long mce_handle_common_ierror(uint64_t srr1)
> switch (P7_SRR1_MC_IFETCH(srr1)) {
> case 0:
> break;
> -#ifdef CONFIG_PPC_MMU_STD_64
> +#ifdef CONFIG_PPC_STD_MMU_64
> case P7_SRR1_MC_IFETCH_SLB_PARITY:
> case P7_SRR1_MC_IFETCH_SLB_MULTIHIT:
> /* flush and reload SLBs for SLB errors. */
> @@ -184,7 +184,7 @@ static long mce_handle_ierror_p7(uint64_t srr1)
>
> handled = mce_handle_common_ierror(srr1);
>
> -#ifdef CONFIG_PPC_MMU_STD_64
> +#ifdef CONFIG_PPC_STD_MMU_64
> if (P7_SRR1_MC_IFETCH(srr1) == P7_SRR1_MC_IFETCH_SLB_BOTH) {
> flush_and_reload_slb();
> handled = 1;
> @@ -332,7 +332,7 @@ static long mce_handle_ierror_p8(uint64_t srr1)
>
> handled = mce_handle_common_ierror(srr1);
>
> -#ifdef CONFIG_PPC_MMU_STD_64
> +#ifdef CONFIG_PPC_STD_MMU_64
> if (P7_SRR1_MC_IFETCH(srr1) == P8_SRR1_MC_IFETCH_ERAT_MULTIHIT) {
> flush_and_reload_slb();
> handled = 1;
> --
> 2.7.4
next prev parent reply other threads:[~2016-05-03 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 6:59 [PATCH] powerpc/mm/radix: fix STD_MMU_64 typo Valentin Rothberg
2016-05-03 9:13 ` Aneesh Kumar K.V [this message]
2016-05-04 22:40 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zis7y04z.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).