* [PATCH] powerpc: fix system.h fallout in sysdev/scom.c [chroma_defconfig]
@ 2012-04-16 5:04 Paul Gortmaker
2012-04-16 8:37 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2012-04-16 5:04 UTC (permalink / raw)
To: benh; +Cc: David Howells, Paul Gortmaker, linuxppc-dev
The following shows up in chroma_defconfig:
CC arch/powerpc/sysdev/scom.o
arch/powerpc/sysdev/scom.c: In function 'scom_debug_init':
arch/powerpc/sysdev/scom.c:182:36: error: 'powerpc_debugfs_root' undeclared (first use in this function)
arch/powerpc/sysdev/scom.c:182:36: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [arch/powerpc/sysdev/scom.o] Error 1
make[1]: *** [arch/powerpc/sysdev/scom.o] Error 2
A bisect leads to commit 9ffc93f203c18a70623f21950f1dd473c9ec48cd
"Remove all #inclusions of asm/system.h"
Add the debug header which contains powerpc_debugfs_root.
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[Ben, let me know if you want to take this or have me keep it.]
diff --git a/arch/powerpc/sysdev/scom.c b/arch/powerpc/sysdev/scom.c
index 49a3ece..702256a 100644
--- a/arch/powerpc/sysdev/scom.c
+++ b/arch/powerpc/sysdev/scom.c
@@ -22,6 +22,7 @@
#include <linux/debugfs.h>
#include <linux/slab.h>
#include <linux/export.h>
+#include <asm/debug.h>
#include <asm/prom.h>
#include <asm/scom.h>
--
1.7.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: fix system.h fallout in sysdev/scom.c [chroma_defconfig]
2012-04-16 5:04 [PATCH] powerpc: fix system.h fallout in sysdev/scom.c [chroma_defconfig] Paul Gortmaker
@ 2012-04-16 8:37 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2012-04-16 8:37 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: dhowells, linuxppc-dev
Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> The following shows up in chroma_defconfig:
>
> CC arch/powerpc/sysdev/scom.o
> arch/powerpc/sysdev/scom.c: In function 'scom_debug_init':
> arch/powerpc/sysdev/scom.c:182:36: error: 'powerpc_debugfs_root' undeclared (first use in this function)
> arch/powerpc/sysdev/scom.c:182:36: note: each undeclared identifier is reported only once for each function it appears in
> make[2]: *** [arch/powerpc/sysdev/scom.o] Error 1
> make[1]: *** [arch/powerpc/sysdev/scom.o] Error 2
>
> A bisect leads to commit 9ffc93f203c18a70623f21950f1dd473c9ec48cd
>
> "Remove all #inclusions of asm/system.h"
>
> Add the debug header which contains powerpc_debugfs_root.
>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-16 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-16 5:04 [PATCH] powerpc: fix system.h fallout in sysdev/scom.c [chroma_defconfig] Paul Gortmaker
2012-04-16 8:37 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).