linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Danny Tsen <dtsen@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
	linux-crypto@vger.kernel.org
Cc: herbert@gondor.apana.org.au, leitao@debian.org,
	nayna@linux.ibm.com, appro@cryptogams.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	mpe@ellerman.id.au, ltcgcw@linux.vnet.ibm.com, dtsen@us.ibm.com
Subject: Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
Date: Fri, 13 Sep 2024 09:02:21 -0500	[thread overview]
Message-ID: <89493ea2-b145-489c-94a5-dad8608b9b79@linux.ibm.com> (raw)
In-Reply-To: <4742a397-eb68-4a79-a2fa-fc45a81e7c2b@csgroup.eu>

Got it.  Thanks.

-Danny

On 9/13/24 8:55 AM, Christophe Leroy wrote:
>
>
> Le 13/09/2024 à 14:30, Danny Tsen a écrit :
>> [Vous ne recevez pas souvent de courriers de dtsen@linux.ibm.com. 
>> Découvrez pourquoi ceci est important à 
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
>> subsequent patches to fix data mismatch over ipsec tunnel.
>
> To deactivate a driver, all you have to do is to add:
>
>     depends on BROKEN
>
> Christophe
>
>
>>
>> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
>> ---
>>   arch/powerpc/crypto/Kconfig | 32 ++++++++++++++++----------------
>>   1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
>> index 09ebcbdfb34f..96ca2c4c8827 100644
>> --- a/arch/powerpc/crypto/Kconfig
>> +++ b/arch/powerpc/crypto/Kconfig
>> @@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
>>            architecture specific assembler implementations that work 
>> on 1KB
>>            tables or 256 bytes S-boxes.
>>
>> -config CRYPTO_AES_GCM_P10
>> -       tristate "Stitched AES/GCM acceleration support on P10 or 
>> later CPU (PPC)"
>> -       depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> -       select CRYPTO_LIB_AES
>> -       select CRYPTO_ALGAPI
>> -       select CRYPTO_AEAD
>> -       select CRYPTO_SKCIPHER
>> -       help
>> -         AEAD cipher: AES cipher algorithms (FIPS-197)
>> -         GCM (Galois/Counter Mode) authenticated encryption mode 
>> (NIST SP800-38D)
>> -         Architecture: powerpc64 using:
>> -           - little-endian
>> -           - Power10 or later features
>> -
>> -         Support for cryptographic acceleration instructions on 
>> Power10 or
>> -         later CPU. This module supports stitched acceleration for 
>> AES/GCM.
>> +#config CRYPTO_AES_GCM_P10
>> +#      tristate "Stitched AES/GCM acceleration support on P10 or 
>> later CPU (PPC)"
>> +#      depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> +#      select CRYPTO_LIB_AES
>> +#      select CRYPTO_ALGAPI
>> +#      select CRYPTO_AEAD
>> +#      select CRYPTO_SKCIPHER
>> +#      help
>> +#        AEAD cipher: AES cipher algorithms (FIPS-197)
>> +#        GCM (Galois/Counter Mode) authenticated encryption mode 
>> (NIST SP800-38D)
>> +#        Architecture: powerpc64 using:
>> +#          - little-endian
>> +#          - Power10 or later features
>> +#
>> +#        Support for cryptographic acceleration instructions on 
>> Power10 or
>> +#        later CPU. This module supports stitched acceleration for 
>> AES/GCM.
>>
>>   config CRYPTO_CHACHA20_P10
>>          tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or 
>> later)"
>> -- 
>> 2.43.0
>>
>>


  reply	other threads:[~2024-09-13 14:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 12:30 [PATCH] crypto: Removing CRYPTO_AES_GCM_P10 Danny Tsen
2024-09-13 13:55 ` Christophe Leroy
2024-09-13 14:02   ` Danny Tsen [this message]
2024-09-19  4:55 ` Michael Ellerman
2024-09-19 11:06   ` Danny Tsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89493ea2-b145-489c-94a5-dad8608b9b79@linux.ibm.com \
    --to=dtsen@linux.ibm.com \
    --cc=appro@cryptogams.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dtsen@us.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=leitao@debian.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ltcgcw@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=nayna@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).