* [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
@ 2024-09-13 12:30 Danny Tsen
2024-09-13 13:55 ` Christophe Leroy
2024-09-19 4:55 ` Michael Ellerman
0 siblings, 2 replies; 5+ messages in thread
From: Danny Tsen @ 2024-09-13 12:30 UTC (permalink / raw)
To: linux-crypto
Cc: herbert, leitao, nayna, appro, linux-kernel, linuxppc-dev, mpe,
ltcgcw, dtsen, Danny Tsen
Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
subsequent patches to fix data mismatch over ipsec tunnel.
Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
---
arch/powerpc/crypto/Kconfig | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
index 09ebcbdfb34f..96ca2c4c8827 100644
--- a/arch/powerpc/crypto/Kconfig
+++ b/arch/powerpc/crypto/Kconfig
@@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
architecture specific assembler implementations that work on 1KB
tables or 256 bytes S-boxes.
-config CRYPTO_AES_GCM_P10
- tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
- depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
- select CRYPTO_LIB_AES
- select CRYPTO_ALGAPI
- select CRYPTO_AEAD
- select CRYPTO_SKCIPHER
- help
- AEAD cipher: AES cipher algorithms (FIPS-197)
- GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
- Architecture: powerpc64 using:
- - little-endian
- - Power10 or later features
-
- Support for cryptographic acceleration instructions on Power10 or
- later CPU. This module supports stitched acceleration for AES/GCM.
+#config CRYPTO_AES_GCM_P10
+# tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
+# depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
+# select CRYPTO_LIB_AES
+# select CRYPTO_ALGAPI
+# select CRYPTO_AEAD
+# select CRYPTO_SKCIPHER
+# help
+# AEAD cipher: AES cipher algorithms (FIPS-197)
+# GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
+# Architecture: powerpc64 using:
+# - little-endian
+# - Power10 or later features
+#
+# Support for cryptographic acceleration instructions on Power10 or
+# later CPU. This module supports stitched acceleration for AES/GCM.
config CRYPTO_CHACHA20_P10
tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)"
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
2024-09-13 12:30 [PATCH] crypto: Removing CRYPTO_AES_GCM_P10 Danny Tsen
@ 2024-09-13 13:55 ` Christophe Leroy
2024-09-13 14:02 ` Danny Tsen
2024-09-19 4:55 ` Michael Ellerman
1 sibling, 1 reply; 5+ messages in thread
From: Christophe Leroy @ 2024-09-13 13:55 UTC (permalink / raw)
To: Danny Tsen, linux-crypto
Cc: herbert, leitao, nayna, appro, linux-kernel, linuxppc-dev, mpe,
ltcgcw, dtsen
Le 13/09/2024 à 14:30, Danny Tsen a écrit :
> [Vous ne recevez pas souvent de courriers de dtsen@linux.ibm.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
> subsequent patches to fix data mismatch over ipsec tunnel.
To deactivate a driver, all you have to do is to add:
depends on BROKEN
Christophe
>
> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
> ---
> arch/powerpc/crypto/Kconfig | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
> index 09ebcbdfb34f..96ca2c4c8827 100644
> --- a/arch/powerpc/crypto/Kconfig
> +++ b/arch/powerpc/crypto/Kconfig
> @@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
> architecture specific assembler implementations that work on 1KB
> tables or 256 bytes S-boxes.
>
> -config CRYPTO_AES_GCM_P10
> - tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
> - depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
> - select CRYPTO_LIB_AES
> - select CRYPTO_ALGAPI
> - select CRYPTO_AEAD
> - select CRYPTO_SKCIPHER
> - help
> - AEAD cipher: AES cipher algorithms (FIPS-197)
> - GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
> - Architecture: powerpc64 using:
> - - little-endian
> - - Power10 or later features
> -
> - Support for cryptographic acceleration instructions on Power10 or
> - later CPU. This module supports stitched acceleration for AES/GCM.
> +#config CRYPTO_AES_GCM_P10
> +# tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
> +# depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
> +# select CRYPTO_LIB_AES
> +# select CRYPTO_ALGAPI
> +# select CRYPTO_AEAD
> +# select CRYPTO_SKCIPHER
> +# help
> +# AEAD cipher: AES cipher algorithms (FIPS-197)
> +# GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
> +# Architecture: powerpc64 using:
> +# - little-endian
> +# - Power10 or later features
> +#
> +# Support for cryptographic acceleration instructions on Power10 or
> +# later CPU. This module supports stitched acceleration for AES/GCM.
>
> config CRYPTO_CHACHA20_P10
> tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)"
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
2024-09-13 13:55 ` Christophe Leroy
@ 2024-09-13 14:02 ` Danny Tsen
0 siblings, 0 replies; 5+ messages in thread
From: Danny Tsen @ 2024-09-13 14:02 UTC (permalink / raw)
To: Christophe Leroy, linux-crypto
Cc: herbert, leitao, nayna, appro, linux-kernel, linuxppc-dev, mpe,
ltcgcw, dtsen
Got it. Thanks.
-Danny
On 9/13/24 8:55 AM, Christophe Leroy wrote:
>
>
> Le 13/09/2024 à 14:30, Danny Tsen a écrit :
>> [Vous ne recevez pas souvent de courriers de dtsen@linux.ibm.com.
>> Découvrez pourquoi ceci est important à
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
>> subsequent patches to fix data mismatch over ipsec tunnel.
>
> To deactivate a driver, all you have to do is to add:
>
> depends on BROKEN
>
> Christophe
>
>
>>
>> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
>> ---
>> arch/powerpc/crypto/Kconfig | 32 ++++++++++++++++----------------
>> 1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
>> index 09ebcbdfb34f..96ca2c4c8827 100644
>> --- a/arch/powerpc/crypto/Kconfig
>> +++ b/arch/powerpc/crypto/Kconfig
>> @@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
>> architecture specific assembler implementations that work
>> on 1KB
>> tables or 256 bytes S-boxes.
>>
>> -config CRYPTO_AES_GCM_P10
>> - tristate "Stitched AES/GCM acceleration support on P10 or
>> later CPU (PPC)"
>> - depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> - select CRYPTO_LIB_AES
>> - select CRYPTO_ALGAPI
>> - select CRYPTO_AEAD
>> - select CRYPTO_SKCIPHER
>> - help
>> - AEAD cipher: AES cipher algorithms (FIPS-197)
>> - GCM (Galois/Counter Mode) authenticated encryption mode
>> (NIST SP800-38D)
>> - Architecture: powerpc64 using:
>> - - little-endian
>> - - Power10 or later features
>> -
>> - Support for cryptographic acceleration instructions on
>> Power10 or
>> - later CPU. This module supports stitched acceleration for
>> AES/GCM.
>> +#config CRYPTO_AES_GCM_P10
>> +# tristate "Stitched AES/GCM acceleration support on P10 or
>> later CPU (PPC)"
>> +# depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> +# select CRYPTO_LIB_AES
>> +# select CRYPTO_ALGAPI
>> +# select CRYPTO_AEAD
>> +# select CRYPTO_SKCIPHER
>> +# help
>> +# AEAD cipher: AES cipher algorithms (FIPS-197)
>> +# GCM (Galois/Counter Mode) authenticated encryption mode
>> (NIST SP800-38D)
>> +# Architecture: powerpc64 using:
>> +# - little-endian
>> +# - Power10 or later features
>> +#
>> +# Support for cryptographic acceleration instructions on
>> Power10 or
>> +# later CPU. This module supports stitched acceleration for
>> AES/GCM.
>>
>> config CRYPTO_CHACHA20_P10
>> tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or
>> later)"
>> --
>> 2.43.0
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
2024-09-13 12:30 [PATCH] crypto: Removing CRYPTO_AES_GCM_P10 Danny Tsen
2024-09-13 13:55 ` Christophe Leroy
@ 2024-09-19 4:55 ` Michael Ellerman
2024-09-19 11:06 ` Danny Tsen
1 sibling, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2024-09-19 4:55 UTC (permalink / raw)
To: Danny Tsen, linux-crypto
Cc: herbert, leitao, nayna, appro, linux-kernel, linuxppc-dev, ltcgcw,
dtsen, Danny Tsen
Danny Tsen <dtsen@linux.ibm.com> writes:
> Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
> subsequent patches to fix data mismatch over ipsec tunnel.
This change log needs to stand on its own. ie. it needs to explain what
the problem is and why the feature is being disabled, without reference
to subsequent patches (which will probably be merged separately).
It should also have a Fixes/stable tag.
And as Christophe said, just adding a dependency on BROKEN is
sufficient.
cheers
> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
> index 09ebcbdfb34f..96ca2c4c8827 100644
> --- a/arch/powerpc/crypto/Kconfig
> +++ b/arch/powerpc/crypto/Kconfig
> @@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
> architecture specific assembler implementations that work on 1KB
> tables or 256 bytes S-boxes.
>
> -config CRYPTO_AES_GCM_P10
> - tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
> - depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
> - select CRYPTO_LIB_AES
> - select CRYPTO_ALGAPI
> - select CRYPTO_AEAD
> - select CRYPTO_SKCIPHER
> - help
> - AEAD cipher: AES cipher algorithms (FIPS-197)
> - GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
> - Architecture: powerpc64 using:
> - - little-endian
> - - Power10 or later features
> -
> - Support for cryptographic acceleration instructions on Power10 or
> - later CPU. This module supports stitched acceleration for AES/GCM.
> +#config CRYPTO_AES_GCM_P10
> +# tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
> +# depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
> +# select CRYPTO_LIB_AES
> +# select CRYPTO_ALGAPI
> +# select CRYPTO_AEAD
> +# select CRYPTO_SKCIPHER
> +# help
> +# AEAD cipher: AES cipher algorithms (FIPS-197)
> +# GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
> +# Architecture: powerpc64 using:
> +# - little-endian
> +# - Power10 or later features
> +#
> +# Support for cryptographic acceleration instructions on Power10 or
> +# later CPU. This module supports stitched acceleration for AES/GCM.
>
> config CRYPTO_CHACHA20_P10
> tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)"
> --
> 2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
2024-09-19 4:55 ` Michael Ellerman
@ 2024-09-19 11:06 ` Danny Tsen
0 siblings, 0 replies; 5+ messages in thread
From: Danny Tsen @ 2024-09-19 11:06 UTC (permalink / raw)
To: Michael Ellerman, linux-crypto
Cc: herbert, leitao, nayna, appro, linux-kernel, linuxppc-dev, ltcgcw,
dtsen
Thanks Michael.
On 9/18/24 11:55 PM, Michael Ellerman wrote:
> Danny Tsen <dtsen@linux.ibm.com> writes:
>> Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
>> subsequent patches to fix data mismatch over ipsec tunnel.
> This change log needs to stand on its own. ie. it needs to explain what
> the problem is and why the feature is being disabled, without reference
> to subsequent patches (which will probably be merged separately).
>
> It should also have a Fixes/stable tag.
>
> And as Christophe said, just adding a dependency on BROKEN is
> sufficient.
>
> cheers
>
>
>> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
>> index 09ebcbdfb34f..96ca2c4c8827 100644
>> --- a/arch/powerpc/crypto/Kconfig
>> +++ b/arch/powerpc/crypto/Kconfig
>> @@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
>> architecture specific assembler implementations that work on 1KB
>> tables or 256 bytes S-boxes.
>>
>> -config CRYPTO_AES_GCM_P10
>> - tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
>> - depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> - select CRYPTO_LIB_AES
>> - select CRYPTO_ALGAPI
>> - select CRYPTO_AEAD
>> - select CRYPTO_SKCIPHER
>> - help
>> - AEAD cipher: AES cipher algorithms (FIPS-197)
>> - GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
>> - Architecture: powerpc64 using:
>> - - little-endian
>> - - Power10 or later features
>> -
>> - Support for cryptographic acceleration instructions on Power10 or
>> - later CPU. This module supports stitched acceleration for AES/GCM.
>> +#config CRYPTO_AES_GCM_P10
>> +# tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
>> +# depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> +# select CRYPTO_LIB_AES
>> +# select CRYPTO_ALGAPI
>> +# select CRYPTO_AEAD
>> +# select CRYPTO_SKCIPHER
>> +# help
>> +# AEAD cipher: AES cipher algorithms (FIPS-197)
>> +# GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
>> +# Architecture: powerpc64 using:
>> +# - little-endian
>> +# - Power10 or later features
>> +#
>> +# Support for cryptographic acceleration instructions on Power10 or
>> +# later CPU. This module supports stitched acceleration for AES/GCM.
>>
>> config CRYPTO_CHACHA20_P10
>> tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)"
>> --
>> 2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-19 11:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-13 12:30 [PATCH] crypto: Removing CRYPTO_AES_GCM_P10 Danny Tsen
2024-09-13 13:55 ` Christophe Leroy
2024-09-13 14:02 ` Danny Tsen
2024-09-19 4:55 ` Michael Ellerman
2024-09-19 11:06 ` Danny Tsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).