Re: [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE

[Venkat Rao Bagalkote <venkat88@linux.ibm.com>]

On 07/04/25 2:10 pm, Madhavan Srinivasan wrote:
> Commit 3d45a3d0d2e6 ("powerpc: Define config option for processors with broadcast TLBIE")
> added a config option PPC_RADIX_BROADCAST_TLBIE to support processors with
> broadcast TLBIE. Since this option is relevant only for RADIX_MMU, add
> a check as a dependency to enable PPC_RADIX_BROADCAST_TLBIE in both
> powernv and pseries configs. This fixes the unmet config dependency
> warning reported
>
>     WARNING: unmet direct dependencies detected for PPC_RADIX_BROADCAST_TLBIE
>       Depends on [n]: PPC_RADIX_MMU [=n]
>       Selected by [y]:
>       - PPC_PSERIES [=y] && PPC64 [=y] && PPC_BOOK3S [=y]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504051857.jRqxM60c-lkp@intel.com/
> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>

Tested this on pseries LPAR and the patch fixes the reported issue. Hence,

Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>

> ---
>   arch/powerpc/platforms/powernv/Kconfig | 2 +-
>   arch/powerpc/platforms/pseries/Kconfig | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig
> index 3fbe0295ce14..95d7ba73d43d 100644
> --- a/arch/powerpc/platforms/powernv/Kconfig
> +++ b/arch/powerpc/platforms/powernv/Kconfig
> @@ -17,7 +17,7 @@ config PPC_POWERNV
>   	select MMU_NOTIFIER
>   	select FORCE_SMP
>   	select ARCH_SUPPORTS_PER_VMA_LOCK
> -	select PPC_RADIX_BROADCAST_TLBIE
> +	select PPC_RADIX_BROADCAST_TLBIE if PPC_RADIX_MMU
>   	default y
>   
>   config OPAL_PRD
> diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig
> index a934c2a262f6..fa3c2fff082a 100644
> --- a/arch/powerpc/platforms/pseries/Kconfig
> +++ b/arch/powerpc/platforms/pseries/Kconfig
> @@ -23,7 +23,7 @@ config PPC_PSERIES
>   	select FORCE_SMP
>   	select SWIOTLB
>   	select ARCH_SUPPORTS_PER_VMA_LOCK
> -	select PPC_RADIX_BROADCAST_TLBIE
> +	select PPC_RADIX_BROADCAST_TLBIE if PPC_RADIX_MMU
>   	default y
>   
>   config PARAVIRT

With out this patch:

  make olddefconfig
   HOSTCC  scripts/basic/fixdep
   HOSTCC  scripts/kconfig/conf.o
   HOSTCC  scripts/kconfig/confdata.o
   HOSTCC  scripts/kconfig/expr.o
   LEX     scripts/kconfig/lexer.lex.c
   YACC    scripts/kconfig/parser.tab.[ch]
   HOSTCC  scripts/kconfig/lexer.lex.o
   HOSTCC  scripts/kconfig/menu.o
   HOSTCC  scripts/kconfig/parser.tab.o
   HOSTCC  scripts/kconfig/preprocess.o
   HOSTCC  scripts/kconfig/symbol.o
   HOSTCC  scripts/kconfig/util.o
   HOSTLD  scripts/kconfig/conf

WARNING: unmet direct dependencies detected for PPC_RADIX_BROADCAST_TLBIE
   Depends on [n]: PPC_RADIX_MMU [=n]
   Selected by [y]:
   - PPC_PSERIES [=y] && PPC64 [=y] && PPC_BOOK3S [=y]
#
# configuration written to .config
#


With this patch:

make olddefconfig
   HOSTCC  scripts/basic/fixdep
   HOSTCC  scripts/kconfig/conf.o
   HOSTCC  scripts/kconfig/confdata.o
   HOSTCC  scripts/kconfig/expr.o
   LEX     scripts/kconfig/lexer.lex.c
   YACC    scripts/kconfig/parser.tab.[ch]
   HOSTCC  scripts/kconfig/lexer.lex.o
   HOSTCC  scripts/kconfig/menu.o
   HOSTCC  scripts/kconfig/parser.tab.o
   HOSTCC  scripts/kconfig/preprocess.o
   HOSTCC  scripts/kconfig/symbol.o
   HOSTCC  scripts/kconfig/util.o
   HOSTLD  scripts/kconfig/conf
#
# No change to .config
#

Regards,

Venkat.