From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D5F45B6F7C for ; Thu, 11 Aug 2011 00:45:29 +1000 (EST) Subject: Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding. Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <20110810141550.GQ4926@sgi.com> Date: Wed, 10 Aug 2011 09:45:17 -0500 Message-Id: <8ED8063F-7227-402A-89D5-7CE69241AF9C@kernel.crashing.org> References: <1312945564-6626-1-git-send-email-holt@sgi.com> <1312945564-6626-6-git-send-email-holt@sgi.com> <4E428BFF.7060402@grandegger.com> <20110810141550.GQ4926@sgi.com> To: Robin Holt Cc: netdev@vger.kernel.org, U Bhaskar-B22300 , socketcan-core@lists.berlios.de, Scott Wood , PPC list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Aug 10, 2011, at 9:15 AM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: >> Hi Robin, >>=20 >> On 08/10/2011 05:06 AM, Robin Holt wrote: >>> In working with the socketcan developers, we have come to the = conclusion >>> the Documentation...fsl-flexcan.txt device tree documentation needs = to >>> be cleaned up. The driver does not depend upon any properties other >>=20 >> Your first sentence could be misleading. Please just describe what = the >> patch does and why, something like: >>=20 >> "This patch cleans up the documentation of the device-tree binding = for >> the Flexcan devices on Freescale's PowerPC and ARM cores. Extra >> properties are not needed as the frequency of the source clock is >> fixed..." and so on. >=20 > I borrowed heavily from your message. ;) >=20 >>> than the required properties so we are removing the file. = Additionally, >>> the p1010*dts* files are not following the standard for node naming = in >>> that they have a trailing -v1.0. >>=20 >>> Signed-off-by: Robin Holt >>> To: Marc Kleine-Budde , >>> To: Wolfgang Grandegger , >>> To: U Bhaskar-B22300 >>> To: Scott Wood >>> Cc: socketcan-core@lists.berlios.de, >>> Cc: netdev@vger.kernel.org, >>> Cc: PPC list >>> Cc: Kumar Gala >>> --- >>> .../devicetree/bindings/net/can/fsl-flexcan.txt | 61 = -------------------- >>> arch/powerpc/boot/dts/p1010rdb.dts | 8 --- >>> arch/powerpc/boot/dts/p1010si.dtsi | 8 +- >>> 3 files changed, 4 insertions(+), 73 deletions(-) >>> delete mode 100644 = Documentation/devicetree/bindings/net/can/fsl-flexcan.txt I don't understand how we can do this? What binding spec covers the = P1010 CAN support if you remove this? - k