From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.infineon.com (smtp2.infineon.com [IPv6:2a00:18f0:1e00:4::4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yHw9h1Y0pzDqBr for ; Fri, 20 Oct 2017 03:58:31 +1100 (AEDT) From: To: CC: , , , , , , , , , , , , , , , Subject: RE: [PATCH 3/4] char/tpm: Improve a size determination in nine functions Date: Thu, 19 Oct 2017 16:58:23 +0000 Message-ID: <8afa2fb8d8704aff804cd8da15e931da@infineon.com> References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <83a166af-aecc-649d-dfe3-a72245345209@users.sourceforge.net> <1508238182.16112.475.camel@linux.intel.com> <20171018144811.klfmzikibuux77pf@linux.intel.com> In-Reply-To: <20171018144811.klfmzikibuux77pf@linux.intel.com> Content-Type: text/plain; charset="Windows-1252" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > On Tue, Oct 17, 2017 at 11:50:05AM +0000, Alexander.Steffen@infineon.com > wrote: > > > > Replace the specification of data structures by pointer dereference= s > > > > as the parameter for the operator "sizeof" to make the correspondin= g > > > > size > > > > determination a bit safer according to the Linux coding style > > > > convention. > > > > > > > > > This patch does one style in favor of the other. > > > > I actually prefer that style, so I'd welcome this change :) > > > > > At the end it's Jarkko's call, though I would NAK this as I think som= e > > > one already told this to you for some other similar patch(es). > > > > > > > > > I even would suggest to stop doing this noisy stuff, which keeps peop= le > > > busy for nothing. > > > > Cleaning up old code is also worth something, even if does not change > > one bit in the assembly output in the end... > > > > Alexander >=20 > Quite insignificant clean up it is that does more harm that gives any > benefit as any new change adds debt to backporting. >=20 > Anyway, this has been a useful patch set for me in the sense that I have > clearer picture now on discarding/accepting commits. Indeed. I have now a better understanding for why some code looks as ugly a= s it does. > One line minor > clean up will be from now on automatic NAK unless it causes a compiler > warning or some other visible side-effect. Not a nice policy, but at least a policy. I have deleted the tasks that I h= ad still planned for other cleanup activities. Alexander