* [PATCH 2/6] powerpc: hash_preload fails to preload under CONFIG_PPC_MM_SLICES
[not found] <exportbomb.1187270320@pinky>
@ 2007-08-16 13:18 ` Andy Whitcroft
0 siblings, 0 replies; only message in thread
From: Andy Whitcroft @ 2007-08-16 13:18 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, linuxppc-dev, Randy Dunlap, Paul Mackerras
Seems that a trailing ';' has slipped onto the end of the
get_slice_psize checks under CONFIG_PPC_MM_SLICES causing us to
return unconditionally and never preload.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
---
arch/powerpc/mm/hash_utils_64.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index f178957..a47151e 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -795,7 +795,7 @@ void hash_preload(struct mm_struct *mm, unsigned long ea,
#ifdef CONFIG_PPC_MM_SLICES
/* We only prefault standard pages for now */
- if (unlikely(get_slice_psize(mm, ea) != mm->context.user_psize));
+ if (unlikely(get_slice_psize(mm, ea) != mm->context.user_psize))
return;
#endif
^ permalink raw reply related [flat|nested] only message in thread