From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: benh@au1.ibm.com, Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH kernel] powerpc/powernv/ioda2: Gracefully fail if too many TCE levels requested
Date: Mon, 6 Mar 2017 15:02:29 +1100 [thread overview]
Message-ID: <8b4cac2a-5c1b-141c-9cc0-997a87b4201e@ozlabs.ru> (raw)
In-Reply-To: <1488771369.2870.123.camel@au1.ibm.com>
On 06/03/17 14:36, Benjamin Herrenschmidt wrote:
> On Mon, 2017-03-06 at 12:28 +1100, Alexey Kardashevskiy wrote:
>> 8192*8192*8192*65536>>40 = 32768TB of addressable memory (but there is no
>> good reason not to use huge pages);
>
> No, 39 bits is half a TB. That's not enough.
Ah. My bad. 55 bits it is. It is 2 "indirect" levels + 1 "direct" level,
each 8192 entries. So 13*3+16=55.
>
>> 8192*8192*8192*4096>>40 = 2048TB or addressable memory (even with 2
>> indirect levels but we can have all 5 levels with 4K IOMMU pages).
>>
>> Looks enough to me...
>>
>> And in this particular patch I am not limiting anything, I just replace
>> already existing EEH condition with -EINVAL. If it is this important to
>> have all 5 levels, then we can switch from alloc_pages_node() to
>> kmem_cache_alloc_node(), in a separate patch.
>>
>>
>> --
>
--
Alexey
next prev parent reply other threads:[~2017-03-06 4:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 4:43 [PATCH kernel] powerpc/powernv/ioda2: Gracefully fail if too many TCE levels requested Alexey Kardashevskiy
2017-02-27 0:53 ` Gavin Shan
2017-02-27 11:00 ` Michael Ellerman
2017-02-28 0:54 ` Alexey Kardashevskiy
2017-03-05 23:03 ` Benjamin Herrenschmidt
2017-03-06 1:28 ` Alexey Kardashevskiy
2017-03-06 3:36 ` Benjamin Herrenschmidt
2017-03-06 4:02 ` Alexey Kardashevskiy [this message]
2017-03-14 11:45 ` [kernel] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4cac2a-5c1b-141c-9cc0-997a87b4201e@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=benh@au1.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).